Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add WebRTC #2232

Merged
merged 22 commits into from
Nov 19, 2024
Merged

Add WebRTC #2232

merged 22 commits into from
Nov 19, 2024

Conversation

autonome
Copy link
Collaborator

@autonome autonome commented Nov 14, 2024

We already had a webrtc group, and three features: WebRTC, WebRTC SCTP, WebRTC Encoded Transform.

Core: Adds more keys into the core feature that were in the spec generated draft, and then all the other misc keys from BCD that weren't yet in here and were not obsolete.

Stats API: Added the WebRTC Stats API as its own thing, since is a huge number of keys related solely to that and we've already cleaved off subfeatures. If we want to go megafeature, happy to roll it back in.

Identity: No action yet. Baseline false, there are a few keys from the that spec which are implemented by different browsers. Likely could be its own sub-feature since is designed to bolt on top.

Priority: No action yet. Single vendor, couple of keys.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Nov 14, 2024
@autonome autonome marked this pull request as ready for review November 15, 2024 10:28
@autonome
Copy link
Collaborator Author

@ddbeck ready for a first pass on the approach.

@autonome
Copy link
Collaborator Author

There are also a few candidates for sub-features if we want to cleave those off into their own thing, eg the error stuff.

@autonome
Copy link
Collaborator Author

Baseline low/false chunks we could split off if you want a more cleanly baseline high core feature:

  • getCapabilities
  • RTCIceTransport and related bits
  • get/setParameters and codec info
  • maybe RTCIceCandidate and properties

features/webrtc-encoded-transform.yml Show resolved Hide resolved
features/webrtc-stats.yml Outdated Show resolved Hide resolved
features/webrtc-stats.yml Outdated Show resolved Hide resolved
features/webrtc-stats.yml Show resolved Hide resolved
features/webrtc.yml Outdated Show resolved Hide resolved
@autonome autonome requested a review from ddbeck November 19, 2024 12:11
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple little fixes to make. Otherwise, I think this is ready.

features/webrtc-stats.yml Outdated Show resolved Hide resolved
features/webrtc-stats.yml Show resolved Hide resolved
@autonome autonome requested a review from ddbeck November 19, 2024 13:17
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants