Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cookies #2236

Merged
merged 2 commits into from
Nov 20, 2024
Merged

Add Cookies #2236

merged 2 commits into from
Nov 20, 2024

Conversation

Elchi3
Copy link
Collaborator

@Elchi3 Elchi3 commented Nov 14, 2024

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Nov 14, 2024
@ddbeck
Copy link
Collaborator

ddbeck commented Nov 20, 2024

I wonder if https://github.com/web-platform-dx/web-features/blob/main/features/cookie-enabled.yml should be part of this?

cookieEnabled only just recently became interoperable, so let's leave it where it is for now. https://github.com/web-platform-dx/web-features/blob/main/features/cookie-enabled.yml.dist#L6

Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty good—I have one optional suggestion for the description.

Also now that I've reviewed this, I'm a little more open to the idea of merging cookieEnabled into this (though I could go either way on it). Unfortunately, doing so would be a breaking release; we could do that (we've got some other possible breakages to make), but if you think it's the right thing to do, please file and issue so we can prep to do that.

This is ready to merge, once you've had a think about my description suggestion. Thank you!

features/cookies.yml Outdated Show resolved Hide resolved
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
@Elchi3
Copy link
Collaborator Author

Elchi3 commented Nov 20, 2024

Again I think it would be better if had a rule about when to merge things back into the "parent" feature. Without such rule, we are again making a judgment call. That said, I'm going to leave things as is and hope that future selves will come up with something that will make this consistent throughout the data.

@Elchi3 Elchi3 merged commit a76c92d into web-platform-dx:main Nov 20, 2024
3 checks passed
@Elchi3 Elchi3 deleted the cookies branch November 20, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants