Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CORS #2237

Merged
merged 3 commits into from
Nov 19, 2024
Merged

Add CORS #2237

merged 3 commits into from
Nov 19, 2024

Conversation

Elchi3
Copy link
Collaborator

@Elchi3 Elchi3 commented Nov 14, 2024

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Nov 14, 2024
ddbeck
ddbeck approved these changes Nov 18, 2024
View reviewed changes
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, with a nit in the description. Two questions though:

  • Do you want to put this in the security group too?
  • Do you want Will's review on this one?

features/cors.yml Outdated Show resolved Hide resolved
Elchi3 and others added 2 commits November 19, 2024 12:10
@Elchi3 @ddbeck
Update features/cors.yml
06da835 
Co-authored-by: Daniel D. Beck <daniel@ddbeck.com>
@Elchi3
Add security group
2c5ea2e
@Elchi3
Copy link
Collaborator Author

Elchi3 commented Nov 19, 2024

cc'ing @wbamberg but merging already. Will, let us know if you have a better short description or other remarks :)

@Elchi3 Elchi3 merged commit 5098ee0 into web-platform-dx:main Nov 19, 2024
3 checks passed
@Elchi3 Elchi3 deleted the cors branch November 19, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddbeck ddbeck ddbeck approved these changes

Assignees
No one assigned
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Elchi3 @ddbeck