Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes discouraged payment related keys #2305

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Removes discouraged payment related keys #2305

merged 2 commits into from
Nov 21, 2024

Conversation

vwallen
Copy link
Contributor

@vwallen vwallen commented Nov 21, 2024

Removes payment related keys as found in #2228

From payment-handler:

  • api.CanMakePaymentEvent.methodData
  • api.CanMakePaymentEvent.modifiers
  • api.CanMakePaymentEvent.paymentRequestOrigin
  • api.CanMakePaymentEvent.topOrigin
  • api.PaymentManager.instruments
  • api.PaymentRequestEvent.instrumentKey

From payment-request:

  • api.PaymentRequest.merchantvalidation_event
  • api.PaymentRequest.shippingAddress
  • api.PaymentRequest.shippingOption
  • api.PaymentRequest.shippingType
  • api.PaymentRequest.shippingaddresschange_event
  • api.PaymentRequest.shippingoptionchange_event

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Nov 21, 2024
@jamesnw jamesnw merged commit 06fda87 into web-platform-dx:main Nov 21, 2024
3 checks passed
@jamesnw jamesnw mentioned this pull request Nov 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamesnw jamesnw jamesnw approved these changes

Assignees
No one assigned
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vwallen @jamesnw