Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add color feature #2313

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Add color feature #2313

merged 1 commit into from
Nov 27, 2024

Conversation

jamesnw
Copy link
Collaborator

@jamesnw jamesnw commented Nov 22, 2024

No description provided.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Nov 22, 2024
autonome
autonome approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@autonome autonome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a vague concern over name disambiguation given how many color related features there are. But this property certainly wins on historical precedence, and references seem to all just say "Color" so 👍🏼

@jamesnw jamesnw merged commit e174110 into web-platform-dx:main Nov 27, 2024
4 checks passed
@jamesnw jamesnw deleted the color branch November 27, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@autonome autonome autonome approved these changes

Assignees
No one assigned
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamesnw @autonome