Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds description list #2342

Merged
merged 4 commits into from
Nov 27, 2024
Merged

Conversation

vwallen
Copy link
Contributor

@vwallen vwallen commented Nov 26, 2024

Builds on and closes #1383

Per #1383 (comment) this feature is inconsistently supported in screen readers (and potentially other assistive tech). The display: contents feature added a BCD key to track accessibility issues with that feature related to focused elements (#1966). I don't think that approach is needed here because that related how the browser exposed those elements to assistive tech, whereas in this case (if I'm reading this correctly) the issue is how screen readers interpret the description list elements.

Co-authored-by: kosamari <mariko.kosaka@gmail.com>
Co-authored-by: captainbrosset <captainbrosset@users.noreply.github.com>
@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Nov 26, 2024
@vwallen vwallen marked this pull request as ready for review November 26, 2024 19:21
@captainbrosset
Copy link
Contributor

Bringing my comment over from #1383, for reference:

One thing to consider: accessibility doesn't seem to be the best with DL. See https://adrianroselli.com/2022/12/brief-note-on-description-list-support.html and https://developer.mozilla.org/en-US/docs/Web/HTML/Element/dl#accessibility
In particular, it looks like keyboard navigation isn't supported everywhere.
Baseline currently doesn't cover assistive tech (see https://github.com/web-platform-dx/web-features/blob/main/docs/baseline.md#non-goals) so this is probably fine as is, but it might be good to do a bit of research for a11y best practices with DL and add a short mention of this in the description.

@jamesnw jamesnw merged commit a872b32 into web-platform-dx:main Nov 27, 2024
3 checks passed
@jamesnw jamesnw deleted the description-list branch November 27, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants