Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more keys to text-box #2611

Merged
merged 2 commits into from
Feb 11, 2025
Merged

Add more keys to text-box #2611

merged 2 commits into from
Feb 11, 2025

Conversation

ddbeck
Copy link
Collaborator

@ddbeck ddbeck commented Feb 5, 2025

This adds value types to text-box.

The ideographic and ideographic-ink values aren't supported by any browser. They shouldn't have been added to BCD; I'll send an upstream PR to fix that.

@github-actions github-actions bot added the feature definition Creating or defining new features or groups of features. label Feb 5, 2025
@ddbeck ddbeck mentioned this pull request Feb 5, 2025
Merged
captainbrosset
captainbrosset reviewed Feb 10, 2025
View reviewed changes
features/text-box.yml.dist Outdated
Comment on lines 10 to 11
# safari: "18.2"
# safari_ios: "18.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://developer.chrome.com/blog/css-text-box-trim says that chrome/edge 133 have support for text-box too. And BCD seems to agree. Do you know why Safari is the only supported browser here?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are conflicts in this file, https://github.com/web-platform-dx/web-features/blob/main/features/text-box.yml.dist looks good on main and I bet that resolving the conflicts will fix this.

@foolip
Copy link
Collaborator

foolip commented Feb 11, 2025

The ideographic and ideographic-ink values aren't supported by any browser. They shouldn't have been added to BCD; I'll send an upstream PR to fix that.

How about not adding them to web-features? If you're removing them from BCD there will be work to remove them here with the next release.

foolip
foolip approved these changes Feb 11, 2025
View reviewed changes
Copy link
Collaborator

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good if dist is regenerated and ideographic stuff is dropped.

@ddbeck
Copy link
Collaborator Author

ddbeck commented Feb 11, 2025

The ideographic removals happened with #2625, which I merged into this PR. Thanks for the reviews, folks!

@ddbeck ddbeck merged commit 72239f9 into web-platform-dx:main Feb 11, 2025
3 checks passed
@ddbeck ddbeck deleted the text-box-keys branch February 11, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@captainbrosset captainbrosset captainbrosset left review comments

@foolip foolip foolip approved these changes

Assignees
No one assigned
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ddbeck @foolip @captainbrosset