Add BCD as a dev dependency #869
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should allow Dependabot to send dependency updates for BCD, and it was stuck at 5.5.18 and 5.5.19 in the package-lock.json files. compute-baseline needs it as a dependency to run tests, and package-lock.json is needed for `npm ci` to work. The top-level package.json needs it as a dependency since it's a peer dependency of compute-baseline, and because `npm test:dist` needs it, and that dependency should be pinned. starting-style.dist.yml needed updating, and those updates should go with dependency bumps. This is a bit convoluted and perhaps will confuse Dependabot, but it's what would make sense if compute-baseline was in a separate repository and we installed it from NPM.
This was referenced Apr 13, 2024
|
Obsoleted by #891. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should allow Dependabot to send dependency updates for BCD, and it
was stuck at 5.5.18 and 5.5.19 in the package-lock.json files.
compute-baseline needs it as a dependency to run tests, and
package-lock.json is needed for
npm cito work.The top-level package.json needs it as a dependency since it's a peer
dependency of compute-baseline, and because
npm test:distneeds it,and that dependency should be pinned. starting-style.dist.yml needed
updating, and those updates should go with dependency bumps.
This is a bit convoluted and perhaps will confuse Dependabot, but it's
what would make sense if compute-baseline was in a separate repository
and we installed it from NPM.