Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .dist.yml for image formats #878

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

foolip
Copy link
Collaborator

@foolip foolip commented Apr 13, 2024

WebP data is from https://caniuse.com/webp. Like for AVIF, partial
support was not captured and left as a TODO.

@ddbeck ddbeck added feature definition Creating or defining new features or groups of features. and removed feature-definition labels Apr 15, 2024
@foolip foolip requested a review from ddbeck April 16, 2024 15:54
@foolip foolip mentioned this pull request Apr 17, 2024
baseline: high
baseline_low_date: 2020-09-16
support:
chrome: "9"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caniuse says this is partial through Chrome 22 (for transparent and lossless images) or 31 (for animated). Was it intended to take the earlier versions?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was intentional yes, and I did the same for AVIF where the Safari version would otherwise change.

I think matching caniuse and treating animations as an essential part of support would be OK too, but my hunch is that still images are the overwhelming use case, and that support for animations would make more sense as notes that don't imply partial implementation.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could expand on the comments then? Something like…

# TODO: Add notes about animated <format> coming later in Chrome (but don't mark this as partially supported)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing, I've updates the notes using that template.

WebP data is from https://caniuse.com/webp.

Notes for animated AVIF and WebP are left as TODOs.
@foolip foolip merged commit 2431ae8 into web-platform-dx:main Apr 18, 2024
3 checks passed
@foolip foolip deleted the dist-image-formats branch April 18, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature definition Creating or defining new features or groups of features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants