-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove relative color syntax from Interop 2022 #104
Comments
@foolip Can you please add this to tomorrow's agenda? |
@emilio Do you agree with the proposal to remove these tests? |
@una @argyleink @sesse can any of you help judge if dropping these tests makes sense for Chromium? |
Yes, removing these for now would be great. |
Here are the test results for ease of review: |
I prepared web-platform-tests/wpt-metadata#2938 to see what it'd look like. |
I think it's fair to assess relative color syntax as not likely to ship in 2022 |
@foolip Is this safe to assume there's consensus to remove the tests? Fwiw, WebKit also has a PR to enable relative color syntax (which would make all those tests pass), but given the lack of signals from CSSWG, my position is to remove them from 2022 for now. |
Pinging @LeaVerou who is the CSS Color 5 editor who did most of the Relative Color Syntax spec work. |
I think it makes total sense to prioritize |
I see zero open issues on RCS. @emilio could you open one, so we know what your issue was? If it was mentioned in passing in another issue feel free to link to that. |
This is not the issue at hand. There is no "prioritization" involved here. The CSSWG resolved that several color related features have standards that are complete, and so the features can be shipped. Relative color syntax was not on that list because it was deemed not ready. The recommendation was that browsers should not ship relative color syntax. Because of this fact, these tests should not be part of the Interop 2022 score. Interop only scores things that are fully standardized and shippable. If you believe the spec is ready, Lea, and browsers should ship, then please raise the issue at the CSSWG to change the past resolution. With such a resolution, this can remain in Interop 2022. If there is work to be done, please ensure it is done, so browses can ship later, and these tests can be removed for now, and added to Interop 2023 later. This issue is not the place to debate whether or not relative color syntax is shippable. Please do that work in the CCSWG. This issue is to clarify whether or not existing WPT for relative color syntax should be included in Interop 2022. |
There is no resolution to change, because there is no resolution that RCS is not ready to ship. For your reference, the three actual resolutions from that discussion are here and here. |
Quoting from w3c/csswg-drafts#7310 (comment) :
There was a resolution, just buried in the conversation. Anyway, I do think it's a bit late at this point in the year to be wondering these kinds of questions for Interop, though I'll let the Chrome team make the final call. |
I had no specific concerns. The only thing I mentioned on the call was that I hadn't reviewed this feature at all, and that I thought flagging such a complex feature as ready to ship when it had not gone through multi-implementor review / etc felt a bit premature, specially given all the churn and specification issues other similar features (like |
I don't have a problem of dropping this from Interop. |
Thanks @sesse! With that, I think we have consensus, so I'll merge web-platform-tests/wpt-metadata#2938. |
** Test List **
** Rationale **
CSSWG has not mentioned relative color syntax is ready to ship (@emilio had concerns with the syntax) unlike color-mix() or gradient color space interpolation, and only WebKit has a working implementation. At this stage of the year, we feel like spec work is not appropriate.
See w3c/csswg-drafts#7310 (comment)
The text was updated successfully, but these errors were encountered: