-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal to remove <audio> element from contain-inline-size-replaced.html #317
Comments
@rwlbuis @cathiechen What do you think? |
Yes, I'm still OK with the change; my thinking from the "additional discussion" linked-issue still applies. (tl;dr: the test is assuming that browsers don't have UA stylesheet rules to apply a particular |
Cathie knows size containment better. FWIW, at the time audio was the only subtest I could not fix (https://bugs.webkit.org/show_bug.cgi?id=244799), so would be nice to get this corrected and passing. |
Sorry for the slow reply! Yes, this change looks good to me! |
Fixes: web-platform-tests/interop#317 R=foolip@chromium.org, chrishtr@chromium.org Change-Id: Ia2b14f61c64c600bca23d9eb57ae4e7dbf5d961f
Fixes: web-platform-tests/interop#317 R=foolip@chromium.org, chrishtr@chromium.org Change-Id: Ia2b14f61c64c600bca23d9eb57ae4e7dbf5d961f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4490304 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Vladimir Levin <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1137342}
…inline-size-replaced test., a=testonly Automatic update from web-platform-tests WPT: Remove audio elements from contain-inline-size-replaced test. Fixes: web-platform-tests/interop#317 R=foolip@chromium.org, chrishtr@chromium.org Change-Id: Ia2b14f61c64c600bca23d9eb57ae4e7dbf5d961f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4490304 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Vladimir Levin <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1137342} -- wpt-commits: d9f5e1fca558380dcfabb8e359c8fc2ab1cd3189 wpt-pr: 39749
…inline-size-replaced test., a=testonly Automatic update from web-platform-tests WPT: Remove audio elements from contain-inline-size-replaced test. Fixes: web-platform-tests/interop#317 R=foolip@chromium.org, chrishtr@chromium.org Change-Id: Ia2b14f61c64c600bca23d9eb57ae4e7dbf5d961f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4490304 Reviewed-by: Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Vladimir Levin <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/main@{#1137342} -- wpt-commits: d9f5e1fca558380dcfabb8e359c8fc2ab1cd3189 wpt-pr: 39749
Test List
https://wpt.fyi/results/css/css-contain/contain-inline-size-replaced.html
Rationale
I'm proposing to remove element subtests from the contain-inline-size-replaced.html tests, which is a part of containment interop
The element is underspecified and is implemented in different ways in different browsers. It is sized differently and responds to containment in different ways. One of the subtests is failing on 3/3 major browsers. The other subtest is failing on 2/3 major browsers.
Additional discussion: web-platform-tests/wpt#39325
The text was updated successfully, but these errors were encountered: