-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Popover #423
Comments
WebKit implements everything except |
I agree with this part, with the caveat that we've got a spec PR open now to add |
In preliminary results for State of HTML 2023, popover was the most common response to the freeform question "Which existing HTML features or browser APIs are you unable to use because of browser differences or lack of support?" See #550 for details. |
https://bugs.webkit.org/show_bug.cgi?id=263081 - This is an example of an interop bug with Popover implementations. |
Someone would need to write a WPT for it |
Also from State of HTML preliminary results, Popover was the feature that respondents expressed the most interest for. Note that this wasn't freeform, it's based on the features the survey asked about experience and sentiment for. |
@foolip You're burying the lede a little bit 😅 Popover came up all over the survey, in freeform and non-freeform questions. The need for native popovers was probably one of the biggest themes (2nd only after stylability IMO). Most interesting known features (not freeform)Out of the respondents who had heard each feature, what % were interested? Popover is the first, with 52% of those who had heard it but not used it selecting that they were interested! Most interesting unknown features (not freeform)Out of the respondents who had not heard each feature, what % were interested? 46% of people who had not even heard of the Popover API before the survey selected they were interested. Top interop pain points
2700 issues / 1755 responses, manually classified Popover is the first one, occupying almost 10% of all complaints! Unable to use for other reasons
Popover is 6th here too, despite not really being relevant (since it's not yet supported really). I suspect people misread the questions and entered things that would be more relevant in the question above (i.e. due to browser support) Top interactivity pain points (freeform)
12th most common complaint was related to the lack of popovers. |
Thank you @LeaVerou for summarizing with nice screenshots! |
Could someone create a link to the tests that will likely be included, without any of |
The OP contains the correct link to the tests: https://wpt.fyi/results/html/semantics/popovers?label=master&label=experimental&aligned I tried, and failed, to come up with a search term that eliminates the tests that end in |
So simple! Thanks. |
Do these tests not rely on anchor positioning? |
Hmm, those are good to highlight. Most rely on just the |
Actually, https://wpt.fyi/results/html/semantics/popovers/popover-invoking-attribute.html?label=experimental&label=master&aligned&q=not%20is%3Atentative contains a bunch of sub-tests that are for |
Just as an fyi there's a firefox intent to ship https://groups.google.com/a/mozilla.org/g/dev-platform/c/hrCP5RBO7mA/m/7w-1OsmbAQAJ |
This refactors the test logic into a shared JS file and splits the popover=hint test code into a new .tentative.html file. Per this comment: web-platform-tests/interop#423 (comment) Bug: 1416284 Change-Id: Idda2716c476cf3d9b8fea724ece6e48d66e1fb62
Another good point. In progress: web-platform-tests/wpt#43436 |
@mfreed7 thanks. |
This refactors the test logic into a shared JS file and splits the popover=hint test code into a new .tentative.html file. Per this comment: web-platform-tests/interop#423 (comment) Bug: 1416284 Change-Id: Idda2716c476cf3d9b8fea724ece6e48d66e1fb62
Per the [1] comment, this test contained things about the anchor attribute which aren't (yet) standardized. So this CL splits those parts out into a separate tentative test. [1] web-platform-tests/interop#423 (comment) Bug: 1309178 Change-Id: I46969c0336a6260b4551ae9111fb0002231464fd
… from popover test, a=testonly Automatic update from web-platform-tests Split out anchor-attribute related stuff from popover test Per the [1] comment, this test contained things about the anchor attribute which aren't (yet) standardized. So this CL splits those parts out into a separate tentative test. [1] web-platform-tests/interop#423 (comment) Bug: 1309178 Change-Id: I46969c0336a6260b4551ae9111fb0002231464fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5082149 Commit-Queue: Joey Arhar <jarharchromium.org> Auto-Submit: Mason Freed <masonfchromium.org> Reviewed-by: Joey Arhar <jarharchromium.org> Cr-Commit-Position: refs/heads/main{#1234212} -- wpt-commits: e905d6af9e32b9cfa514f8950c6ec82e3d59e4ad wpt-pr: 43501 UltraBlame original commit: ca67079c1dd0480e5a32b578c08e09e32d415026
…n-tentative test, a=testonly Automatic update from web-platform-tests Move popover=hint related code out of non-tentative test This refactors the test logic into a shared JS file and splits the popover=hint test code into a new .tentative.html file. Per this comment: web-platform-tests/interop#423 (comment) Bug: 1416284 Change-Id: Idda2716c476cf3d9b8fea724ece6e48d66e1fb62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5074321 Auto-Submit: Mason Freed <masonfchromium.org> Commit-Queue: Joey Arhar <jarharchromium.org> Reviewed-by: Joey Arhar <jarharchromium.org> Cr-Commit-Position: refs/heads/main{#1234222} -- wpt-commits: fcd111f4f95c9dae1d0dd7f938fe427699534bc0 wpt-pr: 43436 UltraBlame original commit: 86d6622633a3fc6fae712f86f82871e1bae69e87
… from popover test, a=testonly Automatic update from web-platform-tests Split out anchor-attribute related stuff from popover test Per the [1] comment, this test contained things about the anchor attribute which aren't (yet) standardized. So this CL splits those parts out into a separate tentative test. [1] web-platform-tests/interop#423 (comment) Bug: 1309178 Change-Id: I46969c0336a6260b4551ae9111fb0002231464fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5082149 Commit-Queue: Joey Arhar <jarhar@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1234212} -- wpt-commits: e905d6af9e32b9cfa514f8950c6ec82e3d59e4ad wpt-pr: 43501
…n-tentative test, a=testonly Automatic update from web-platform-tests Move popover=hint related code out of non-tentative test This refactors the test logic into a shared JS file and splits the popover=hint test code into a new .tentative.html file. Per this comment: web-platform-tests/interop#423 (comment) Bug: 1416284 Change-Id: Idda2716c476cf3d9b8fea724ece6e48d66e1fb62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5074321 Auto-Submit: Mason Freed <masonf@chromium.org> Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by: Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/main@{#1234222} -- wpt-commits: fcd111f4f95c9dae1d0dd7f938fe427699534bc0 wpt-pr: 43436
This proposal has been accepted as part of Interop 2024! On behalf of the entire Interop team, thank you for proposing it. You’ll be able to track progress on this topic throughout the year via the Interop 2024 dashboard. |
Thank you for proposing Popover for inclusion in Interop 2024. We are pleased to let you know that this proposal was accepted as part of the Popover focus area. You can follow the progress of this focus area on the Interop 2024 dashboard. For an overview of our process, see the proposal selection. Thank you for contributing to Interop 2024! Posted on behalf of the Interop team. |
I'm not sure where is the most appropriate place to raise this so noting here. html/semantics/popovers/popover-shadow-dom.html - This test is part of interop2024 but has 2 subtests that rely on the anchor attribute which isn't part of interop (nor specced fully afaik). |
@mfreed7 Can we get these split out from the test ? |
Thanks @lukewarlow
A "Test Change Proposal" issue: https://github.com/web-platform-tests/interop/issues/new/choose |
Yep, I can take care of this. I'll comment back here with a PR once I've had a chance to get it started. |
This was noted here: web-platform-tests/interop#423 (comment) Bug: 40059176 Change-Id: I58f3674d2901b8ca7df4c5d5ba8ed99c0b62a4de
|
This was noted here: web-platform-tests/interop#423 (comment) Bug: 40059176 Change-Id: I58f3674d2901b8ca7df4c5d5ba8ed99c0b62a4de
This was noted here: web-platform-tests/interop#423 (comment) Bug: 40059176 Change-Id: I58f3674d2901b8ca7df4c5d5ba8ed99c0b62a4de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5310497 Commit-Queue: Di Zhang <dizhangg@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Reviewed-by: Di Zhang <dizhangg@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1262923}
This was noted here: web-platform-tests/interop#423 (comment) Bug: 40059176 Change-Id: I58f3674d2901b8ca7df4c5d5ba8ed99c0b62a4de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5310497 Commit-Queue: Di Zhang <dizhangg@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Reviewed-by: Di Zhang <dizhangg@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1262923}
This was noted here: web-platform-tests/interop#423 (comment) Bug: 40059176 Change-Id: I58f3674d2901b8ca7df4c5d5ba8ed99c0b62a4de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5310497 Commit-Queue: Di Zhang <dizhangg@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Reviewed-by: Di Zhang <dizhangg@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1262923}
…nto tentative test, a=testonly Automatic update from web-platform-tests Split out popover tests using `anchor` into tentative test This was noted here: web-platform-tests/interop#423 (comment) Bug: 40059176 Change-Id: I58f3674d2901b8ca7df4c5d5ba8ed99c0b62a4de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5310497 Commit-Queue: Di Zhang <dizhangg@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Reviewed-by: Di Zhang <dizhangg@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1262923} -- wpt-commits: c00ad32611211eced99cb946e6cb4710d68b9aee wpt-pr: 44679
…nto tentative test, a=testonly Automatic update from web-platform-tests Split out popover tests using `anchor` into tentative test This was noted here: web-platform-tests/interop#423 (comment) Bug: 40059176 Change-Id: I58f3674d2901b8ca7df4c5d5ba8ed99c0b62a4de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5310497 Commit-Queue: Di Zhang <dizhangg@chromium.org> Auto-Submit: Mason Freed <masonf@chromium.org> Reviewed-by: Di Zhang <dizhangg@chromium.org> Commit-Queue: Mason Freed <masonf@chromium.org> Cr-Commit-Position: refs/heads/main@{#1262923} -- wpt-commits: c00ad32611211eced99cb946e6cb4710d68b9aee wpt-pr: 44679
::backdrop not supported css variable! Example ::backdrop { Variables won't work! If to change on ::backdrop { all will be works |
@promocot if you're running into this issue in Chrome, it was fixed in https://chromestatus.com/feature/4875749691752448, in Chrome 122. https://wpt.fyi/results/html/semantics/interactive-elements/the-dialog-element/backdrop-inherits.html?label=master&label=stable is the relevant test for this, and it looks like it was previously failing (but now passing) in Safari as well. If you have a problem in the latest version of each browser, please file bug reports in the appropriate bug tracker. |
Hello, thanks, I tried to update manual my chrome browser, and yep after works, but i found another bug with close popover on clic to icon. For example, I have a HTML
If I click on show button i will see popup, if i click on hide button i will close popup, but if i have structure like this
when i click on show button i will see popup, and if i try to click on the hide button, nothing happens |
@promocot I see you're missing a If you have more question please try Stack Overflow, and if you think there are browser bugs file a bug with the appropriate browser. This issue was to track popover for inclusion in Interop 2024, and is not a good place to ask for help with popover. |
I am not missing the button in the second example, I place the button inside the popover as a close button. I tested in chrome. Ok i will try to write email for chrome developers |
I found a problem, in my test case i used attribute for SVG icon not button but if I add a button with an icon, and set the attribute for the button, all works |
@promocot that's interesting, do you mean you were trying to add the |
Yes, I will write about this with a video demo and codeopen |
Description
The popover attribute allows creating dropdown UIs using platform features, solving the case of a dropdown being cut by the overflow behavior of the container (as it goes in the top layer) and without requiring JS to trigger it (thanks to
popovertarget
.This is already implemented in Blink and is partially implemented in Webkit. Reaching interop would allow relying on it.
Thus, due to the top-layer behavior, it is hard (or maybe even impossible) to polyfill this feature.
Specification
https://html.spec.whatwg.org/multipage/popover.html#the-popover-attribute
Open Issues
No response
Tests
https://wpt.fyi/results/html/semantics/popovers?label=master&label=experimental&aligned
Maybe also https://wpt.fyi/results/close-watcher/popover-closewatcher.html?label=master&label=experimental&aligned and https://wpt.fyi/results/close-watcher/popover-closewatcher-multiple-plus-free.html?label=master&label=experimental&aligned but not sure about them
Current Implementations
Standards Positions
mozilla/standards-positions#698
WebKit/standards-positions#74
Browser bug reports
https://bugzilla.mozilla.org/show_bug.cgi?id=1808823
https://bugs.chromium.org/p/chromium/issues/detail?id=1307772
https://bugs.webkit.org/show_bug.cgi?id=250171
Developer discussions
No response
Polls & Surveys
No response
Existing Usage
No response
Workarounds
No response
Accessibility Impact
No response
Privacy Impact
No response
Other
No response
The text was updated successfully, but these errors were encountered: