Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests of requestVideoFrameCallback Focus Area should not require support for WebXR on desktop #672

Closed
jensimmons opened this issue Jul 1, 2024 · 2 comments · Fixed by web-platform-tests/wpt-metadata#6506
Labels
test-change-proposal Proposal to add or remove tests for an interop area

Comments

@jensimmons
Copy link
Contributor

jensimmons commented Jul 1, 2024

Test List

https://wpt.fyi/results/video-rvfc/request-video-frame-callback-before-xr-session.https.html?label=experimental&label=master&aligned&view=interop&q=label%3Ainterop-2024-video-rvfc

https://wpt.fyi/results/video-rvfc/request-video-frame-callback-during-xr-session.https.html?label=master&label=experimental&aligned&view=interop&q=label%3Ainterop-2024-video-rvfc

Rationale

These two tests depend on the existence of WebXR. Safari on macOS fails these subtests because WebXR is not supported on Mac.

A dependency on an unrelated technology that's not core to the focus area shouldn't be a blocker. Ideally, these tests would be run on the appropriate platform — for Safari that would be visionOS. But since that's not possible, these two tests should be unlabeled and not included in Interop 2024.

@jensimmons jensimmons added the test-change-proposal Proposal to add or remove tests for an interop area label Jul 1, 2024
@jensimmons jensimmons changed the title Tests of requestVideoFrameCallback Focus Area should not include WebXR on desktop Tests of requestVideoFrameCallback Focus Area should not require WebXR on desktop support Jul 1, 2024
@jensimmons jensimmons changed the title Tests of requestVideoFrameCallback Focus Area should not require WebXR on desktop support Tests of requestVideoFrameCallback Focus Area should not require support for WebXR on desktop Jul 1, 2024
@jgraham
Copy link
Contributor

jgraham commented Jul 11, 2024

Agreed that anything that relies on WebXR is out of scope and should be removed.

@foolip
Copy link
Member

foolip commented Jul 11, 2024

Discussed briefly in #674 and we have consensus to exclude these tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test-change-proposal Proposal to add or remove tests for an interop area
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants