This repository has been archived by the owner on Nov 6, 2019. It is now read-only.
Rename /latest endpoint to /json #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kereliuk
reviewed
Oct 24, 2017
jeffcarp
reviewed
Oct 24, 2017
json_redirect_handler.go
Outdated
| // | ||
| // Params: | ||
| // platform: Browser (and OS) of the run, e.g. "chrome-63.0" or "safari" | ||
| // (optional) run: SHA[0:10] of the test run |
There was a problem hiding this comment.
This should mention it defaults to "latest"
jeffcarp
approved these changes
Oct 24, 2017
|
Note that I wanted both commits, unsquashed, because file renames and modifications in the same commit doesn't get handled well in Git. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Considering /latest might make more sense with respect to #172, /json is a more appropriate endpoint name for fetching the JSON blob of a given run (for #161)
/cc @JKereliuk