Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Add TestDriver support for the generate_test_report WebDriver extension command. #7

Closed
paulmeyer90 opened this issue Feb 11, 2019 · 7 comments

Comments

@paulmeyer90
Copy link
Contributor

paulmeyer90 commented Feb 11, 2019

Summary

I propose to add TestDriver support for the "generate_test_report" WebDriver command, which will allow generic reports to be consistently generated during web platform tests. This command is specced as part of the Reporting API spec here.

Motivation

The real-world causes of reports (like deprecations, interventions, and crashes) can differ between different user agents. In order to test reporting consistently, we need the ability to generate reports universally across the web platform. This command provides that ability.

Risks

I am not aware of any risks.

Details

No additional details.

@paulmeyer90 paulmeyer90 changed the title RFC: Implement the generate_test_report WebDriver extension command. RFC: Add TestDriver support for the generate_test_report WebDriver extension command. Feb 11, 2019
@jgraham
Copy link
Contributor

jgraham commented Feb 11, 2019

This is somewhat off-topic, but I think the way that spec introduces the command isn't what WebDriver intends; it isn't clear what the actual URL for the endpoint is. I don't think you need to define a prefix or anything in this case, just state what the URL is (because this extension isn't a vendor extension).

In any case I think this proposal looks fine, although to be clear that shouldn't be read as any kind of statement on the overall Reporting API spec, which I know nothing about. I assume that were the spec to change, you would keep the tests and testdriver up-to-date with the current spec.

@paulmeyer90
Copy link
Contributor Author

Okay, so to clarify, are you suggesting that I just combine the listed Prefix and Name into one URL field?

If not, could you point me to an example of the format you're looking for?

@jgraham
Copy link
Contributor

jgraham commented Feb 11, 2019

Okay, so to clarify, are you suggesting that I just combine the listed Prefix and Name into one URL field?

Yes.

@paulmeyer90
Copy link
Contributor Author

Reporting spec updated here: w3c/reporting#150

@foolip
Copy link
Member

foolip commented Feb 12, 2019

This LGTM, glad you could make it all work together, @paulmeyer90! @LukeZielinski FYI, new automation API incoming.

@foolip
Copy link
Member

foolip commented Feb 18, 2019

@paulmeyer90 we've reached "In the case of no substantive disagreement the RFC is considered accepted after 1 week" in the process now. However, #9 suggets doing RFCs in files in the repo instead. Would you be willing to submit a PR with this as a markdown file so we have it for all RFCs? (We just launched this process, tweaking as we go.)

@foolip
Copy link
Member

foolip commented Feb 19, 2019

This will be resolved by #13, thanks @paulmeyer90 and @jgraham!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants