Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document that no RFC is needed for most testdriver.js additions #123

Merged
merged 2 commits into from
Jan 26, 2023
Merged

Document that no RFC is needed for most testdriver.js additions #123

merged 2 commits into from
Jan 26, 2023

Conversation

foolip
Copy link
Member

@foolip foolip commented Oct 4, 2022

No description provided.

Ms2ger
Ms2ger approved these changes Oct 5, 2022
View reviewed changes
Copy link
Contributor

@Ms2ger Ms2ger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me

@jgraham
Copy link
Contributor

jgraham commented Oct 5, 2022

I think we decided that this should itself be an RFC.

@foolip foolip marked this pull request as draft October 5, 2022 13:58
@foolip
Copy link
Member Author

foolip commented Oct 5, 2022

@past agreed to turn it into a RFC. It's pretty much this language, plus stating that there should be tests.

@jcscottiii jcscottiii mentioned this pull request Nov 4, 2022
Merged
@jcscottiii
Copy link
Contributor

@foolip Now that #127 is merged, this can be merged. Are there any remaining changes to this PR?

@foolip foolip marked this pull request as ready for review December 6, 2022 14:51
@foolip
Copy link
Member Author

foolip commented Dec 6, 2022

@jcscottiii I've updated the REAME to link to the RFC as well. Does that look OK?

@foolip foolip merged commit 48ec4ee into master Jan 26, 2023
@foolip foolip deleted the testdriver-additions branch January 26, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcscottiii jcscottiii jcscottiii approved these changes

@Ms2ger Ms2ger Ms2ger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@foolip @jgraham @jcscottiii @Ms2ger