Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC 18 - Simplify License #18

Merged
merged 4 commits into from
Apr 25, 2019
Merged

Conversation

jugglinmike
Copy link
Contributor

This RFC is an attempt to restart a stalled discussion from 2018. Since opinions on this topic may differ among the newly-formed WPT Core Team, the team may want to reach consensus before requesting approval from @wseltzer and the Patents and Standards Interest Group.

Also note that there are two subtly different pull requests implementing this change: gh-11191 and gh-13650. The team should decide which of these is desired.

Separately: is it appropriate to reference individuals in non-technical RFCs like this? Using GitHub handles seemed too informal (and proprietary besides), but I'm not sure if it's presumptuous to use real names. And while I think listing each person's respective organization enhances inclusiveness by avoiding industry-specific knowledge, it might suggest endorsement in a way that's not accurate.

Here's the rendered version.

/cc @annevk and @plehegar

@foolip
Copy link
Member

foolip commented Mar 19, 2019

To allow ample time for on- and off-thread discussion about this, I request that we increase the discussion period to two weeks for this one.

@jgraham
Copy link
Contributor

jgraham commented Mar 26, 2019

Please put the full text of the proposed license in the RFC.

@jugglinmike
Copy link
Contributor Author

Sure thing. The RFC now includes the text from WPT pull request gh-11191, modified only to update the license year.

rfcs/simplify_license.md Outdated Show resolved Hide resolved

### Summary

Reduce WPT's license to the 3-clause BSD license and update the copyright
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3-Clause BSD License*

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wasn't fixed (the casing).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry about that! This patch mentions the license by name twice; I didn't realize that and marked your comment as "resolved" when I corrected the second

@jugglinmike
Copy link
Contributor Author

This should probably list the source "opensource.org" for completeness. And maybe someone should double check it's still the same.

Confirming that this matches the license published at https://opensource.org/licenses/BSD-3-Clause

Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this, I'm certainly happy with this.

@foolip
Copy link
Member

foolip commented Apr 3, 2019

I'm happy with this after internal consultation.

There is one additional change I think needs to be made together with this or shortly after, and that's to update https://github.com/web-platform-tests/wpt/blob/master/CONTRIBUTING.md to simply say that the contribution is licensed under the license. @jugglinmike would you like roll that into this change?

@foolip
Copy link
Member

foolip commented Apr 18, 2019

Ping @jugglinmike on CONTRIBUTING.md issue.

@jugglinmike
Copy link
Contributor Author

@foolip The change to the CONTRIBUTING.md file in WPT sounds good to me. I think I'm misinterpreting your suggestion to roll it into this patch because the file is in another repository. Are you suggesting that the RFC document explains how we will modify CONTRIBUTING.md in WPT?

@foolip
Copy link
Member

foolip commented Apr 18, 2019

Yes, accepting this RFC will mean merging one or more PRs in wpt. We have one for the license, but if you could prepare the changes to CONTRIBUTING.md, then I think this RFC is good to go.

@jugglinmike
Copy link
Contributor Author

Got it, @foolip. I just pushed to @annevk's branch for gh-11191, updating the year and reducing the contents of the CONTRIBUTING.md file to the following statement:

All contributions are licensed under the terms of the LICENSE.md file.

@foolip
Copy link
Member

foolip commented Apr 25, 2019

Thanks @jugglinmike and sorry for the delay. web-platform-tests/wpt#11191 now LGTM, so if there's nothing further we can merge that and this PR. (I'll check with @jgraham today.)

@foolip
Copy link
Member

foolip commented Apr 25, 2019

Checked with @jgraham, no concerns, let's do it.

But I'd like to merge web-platform-tests/wpt#13650 to make it clear that this was OK with @wseltzer, I'll compare the PRs to see if there are still differences.

@foolip
Copy link
Member

foolip commented Apr 25, 2019

There was a change of plans after discussing with @annevk on IRC, and I merged web-platform-tests/wpt#11191 and commented a bit on both PRs about their relationship.

I'll now go ahead and merge this PR as well, finally resolving the license issue after all this time. Thank you everyone who helped make this possible!

@foolip foolip merged commit 87298ad into web-platform-tests:master Apr 25, 2019
@foolip
Copy link
Member

foolip commented Feb 18, 2020

I just discovered that we left some copies of the W3C 3-clause BSD License behind and have sent web-platform-tests/wpt#21851 to remove them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants