-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC 18 - Simplify License #18
Conversation
To allow ample time for on- and off-thread discussion about this, I request that we increase the discussion period to two weeks for this one. |
Please put the full text of the proposed license in the RFC. |
Sure thing. The RFC now includes the text from WPT pull request gh-11191, modified only to update the license year. |
rfcs/simplify_license.md
Outdated
|
||
### Summary | ||
|
||
Reduce WPT's license to the 3-clause BSD license and update the copyright |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3-Clause BSD License*
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This wasn't fixed (the casing).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, sorry about that! This patch mentions the license by name twice; I didn't realize that and marked your comment as "resolved" when I corrected the second
Confirming that this matches the license published at https://opensource.org/licenses/BSD-3-Clause |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this, I'm certainly happy with this.
I'm happy with this after internal consultation. There is one additional change I think needs to be made together with this or shortly after, and that's to update https://github.com/web-platform-tests/wpt/blob/master/CONTRIBUTING.md to simply say that the contribution is licensed under the license. @jugglinmike would you like roll that into this change? |
Ping @jugglinmike on CONTRIBUTING.md issue. |
@foolip The change to the |
Yes, accepting this RFC will mean merging one or more PRs in wpt. We have one for the license, but if you could prepare the changes to CONTRIBUTING.md, then I think this RFC is good to go. |
Thanks @jugglinmike and sorry for the delay. web-platform-tests/wpt#11191 now LGTM, so if there's nothing further we can merge that and this PR. (I'll check with @jgraham today.) |
Checked with @jgraham, no concerns, let's do it. But I'd like to merge web-platform-tests/wpt#13650 to make it clear that this was OK with @wseltzer, I'll compare the PRs to see if there are still differences. |
There was a change of plans after discussing with @annevk on IRC, and I merged web-platform-tests/wpt#11191 and commented a bit on both PRs about their relationship. I'll now go ahead and merge this PR as well, finally resolving the license issue after all this time. Thank you everyone who helped make this possible! |
I just discovered that we left some copies of the W3C 3-clause BSD License behind and have sent web-platform-tests/wpt#21851 to remove them. |
This RFC is an attempt to restart a stalled discussion from 2018. Since opinions on this topic may differ among the newly-formed WPT Core Team, the team may want to reach consensus before requesting approval from @wseltzer and the Patents and Standards Interest Group.
Also note that there are two subtly different pull requests implementing this change: gh-11191 and gh-13650. The team should decide which of these is desired.
Separately: is it appropriate to reference individuals in non-technical RFCs like this? Using GitHub handles seemed too informal (and proprietary besides), but I'm not sure if it's presumptuous to use real names. And while I think listing each person's respective organization enhances inclusiveness by avoiding industry-specific knowledge, it might suggest endorsement in a way that's not accurate.
Here's the rendered version.
/cc @annevk and @plehegar