Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Go to version 1.22 #4008

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Upgrade Go to version 1.22 #4008

merged 1 commit into from
Sep 20, 2024

Conversation

past
Copy link
Member

@past past commented Sep 20, 2024

The next step in the Go module updates saga. This includes a lint warning fix and running go get -u ./... ; go mod tidy.

@past
Copy link
Member Author

past commented Sep 20, 2024

The checks fail because they run on webplatformtests/wpt.fyi:latest instead of webplatformtests/wpt.fyi:past-upgrade-modules. Every test passes locally.

@KyleJu
Copy link
Collaborator

KyleJu commented Sep 20, 2024

The checks fail because they run on webplatformtests/wpt.fyi:latest instead of webplatformtests/wpt.fyi:past-upgrade-modules. Every test passes locally.

That is correct. However, in the Go 1.21 update PR, the check also uses webplatformtests/wpt.fyi:latest but the CI passes. How did that pass?

Also confirm that I can see the docker image built in this branch

go.mod Show resolved Hide resolved
@past
Copy link
Member Author

past commented Sep 20, 2024

That is correct. However, in the Go 1.21 update PR, the check also uses webplatformtests/wpt.fyi:latest but the CI passes. How did that pass?

Because that PR didn't change the go.mod version format and Go 1.20 was still able to parse it. Essentially PRs that touch Dockerfile may or may not pass, depending on how backwards-compatible these changes are.

@past past merged commit 76ccaff into main Sep 20, 2024
8 of 13 checks passed
@past past deleted the past/upgrade-modules branch September 20, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants