Implement a GitHub webhook for Taskcluster #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Staging instance deployed by Travis CI! |
lukebjerring
suggested changes
Sep 12, 2018
The webhook listens to GitHub "status" events (i.e. all status updates for all commits from all CI integration), but only reacts to the "success" event from Taskcluster on master. When it receives such events, it will query Taskcluster API for metadata, from which it extracts task info, constructs a list of artifact URLs (wptreport.json.gz), and sends the URLs to the results receiver.
Implement the payload verification according to https://developer.github.com/webhooks/securing/
Hexcles
force-pushed
the
taskcluster-webhook
branch
from
682d128
to
9cf06dc
Compare
|
@lukebjerring HMAC has been added and tested in my staging deployment. PTAL. |
lukebjerring
approved these changes
Sep 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The webhook listens to GitHub "status" events (i.e. all status updates
for all commits from all CI integration), but only reacts to the
"success" event from Taskcluster on master. When it receives such
events, it will query Taskcluster API for metadata, from which it
extracts task info, constructs a list of artifact URLs
(wptreport.json.gz), and sends the URLs to the results receiver.
Review Information
In addition to unit tests, the code has already been deployed in my personal GCP and correctly sending results to the staging receiver: https://staging.wpt.fyi/test-runs?labels=taskcluster