Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plumb diff filter params through the UI #722

Merged
merged 4 commits into from
Nov 6, 2018
Merged

Plumb diff filter params through the UI #722

merged 4 commits into from
Nov 6, 2018

Conversation

lukebjerring
Copy link
Contributor

@lukebjerring lukebjerring commented Nov 2, 2018

Description

Splits path param from filter for parsing, and plumbs the value to the webcomponent.
We'll need this to make the UI ignore tests that didn't run on a PR.

Also changes the /api/diff endpoint to allow anything that produces exactly 2 results, e.g. ?product=chrome&max-count=2

Review Information

Load some filtered view, e.g. /results?products=chrome[experimental],chrome[stable]&diff&filter=U will only show unchanged things (kinda useless, but easy to tell it works).

@wpt-pr-bot
Copy link

Staging instance deployed by Travis CI!
Running at https://diff-filter-dot-wptdashboard-staging.appspot.com

@wpt-pr-bot
Copy link

Staging instance deployed by Travis CI!
Running at https://diff-filter-dot-announcer-dot-wptdashboard-staging.appspot.com

@foolip
Copy link
Member

foolip commented Nov 6, 2018

Confirmed that /results?products=chrome[experimental],chrome[stable]&diff&filter=U does something.

Copy link
Member

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.replace('product', 'before')
.replace('product', 'after');
url.search = query;
const productParams = url.searchParams.getAll('product');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is nicer now :)

@lukebjerring
Copy link
Contributor Author

Yeah, as discussed offline,

Take beacon-basic-blob.html for example. The UI shows it as 0 / 0 / 0, but if you see the /api/diff fetch:
https://diff-filter-dot-wptdashboard-staging.appspot.com/api/diff?before=chrome%5Bexperimental%5D&after=chrome%5Bstable%5D&filter=C you don't see beacon-basic-blob.html in the result.

So, as you say, I'll be improving the client-side filtering to match the same behaviour in the UI.

@lukebjerring lukebjerring merged commit 36058b5 into master Nov 6, 2018
@lukebjerring lukebjerring deleted the diff-filter branch November 6, 2018 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants