Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert "Check if math expression has percentages deep inside"
This reverts commit fc365dddd74a2c9ba22036fd5563dbea8ff34c7c. Reason for revert: failures of external/wpt/css/css-values/signs-abs-computed.html on at least https://ci.chromium.org/ui/p/chromium/builders/ci/mac13-arm64-rel-tests/10874/test-results Original change's description: > Check if math expression has percentages deep inside > > Currently, only the top level category is checked to have a percentage > dependency, check all the nodes inside the expression as well, > as it can be the case like: > NumberProducingFunction(Percentage) * Pixels. > The top level category is Length in such case and we try to resolve it > with ComputeLength, where percentages are not allowed. > > Note: the added test would crash before the CL, as it would try to > GetDouble() of percentage which is not allowed in that context. > > Bug: 1505817 > Change-Id: Iefd13c0d190c3b8adf463ea244f81331635e14fe > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5064155 > Commit-Queue: Daniil Sakhapov <sakhapov@chromium.org> > Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1230671} Bug: 1505817 Change-Id: I8ce6bd91c3b69cdbb6036d3ad73b08c200447ea7 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5070884 Owners-Override: David Baron <dbaron@chromium.org> Auto-Submit: David Baron <dbaron@chromium.org> Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Cr-Commit-Position: refs/heads/main@{#1230704}
- Loading branch information