Skip to content

Commit

Permalink
Revert "Check if math expression has percentages deep inside"
Browse files Browse the repository at this point in the history
This reverts commit fc365dddd74a2c9ba22036fd5563dbea8ff34c7c.

Reason for revert: failures of external/wpt/css/css-values/signs-abs-computed.html on at least https://ci.chromium.org/ui/p/chromium/builders/ci/mac13-arm64-rel-tests/10874/test-results

Original change's description:
> Check if math expression has percentages deep inside
>
> Currently, only the top level category is checked to have a percentage
> dependency, check all the nodes inside the expression as well,
> as it can be the case like:
> NumberProducingFunction(Percentage) * Pixels.
> The top level category is Length in such case and we try to resolve it
> with ComputeLength, where percentages are not allowed.
>
> Note: the added test would crash before the CL, as it would try to
> GetDouble() of percentage which is not allowed in that context.
>
> Bug: 1505817
> Change-Id: Iefd13c0d190c3b8adf463ea244f81331635e14fe
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5064155
> Commit-Queue: Daniil Sakhapov <sakhapov@chromium.org>
> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1230671}

Bug: 1505817
Change-Id: I8ce6bd91c3b69cdbb6036d3ad73b08c200447ea7
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5070884
Owners-Override: David Baron <dbaron@chromium.org>
Auto-Submit: David Baron <dbaron@chromium.org>
Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1230704}
  • Loading branch information
dbaron authored and chromium-wpt-export-bot committed Nov 29, 2023
1 parent 105ae9b commit 014c3ae
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion css/css-values/signs-abs-computed.html
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,5 @@
test_length_equals('sign(10px - 2em)', '-1', 'fontSize=10px');
document.getElementById('container').style.fontSize = '20px';

test_math_used('calc(sign(10%) * 100px)', '100px');

</script>

0 comments on commit 014c3ae

Please sign in to comment.