-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert "[LCP] Add animated image support"
This reverts commit b7d510c06e0436cfb4bd7260175cd460b949225c. Reason for revert: speculative revert for new flakiness in PageLoadMetricsBrowserTestWithAnimatedLCPFlag, see first failing build https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29/99853 Original change's description: > [LCP] Add animated image support > > This CL adds support for better handling of animated images in LCP: > * A new attribute is exposing the first animated frame's paint time > (behind a flag). > * `startTime` is not changed. > * The PageLoadMetrics reported for LCP are set to that first frame paint > time for animated images (behind another flag). > * Entries are not emitted until the image is loaded. > > Relevant spec issue: > w3c/largest-contentful-paint#83 > > Change-Id: I6bb01eacb4f200f9c032ffcfcd9a1a41126a7773 > Bug: 1260953 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3226157 > Commit-Queue: Yoav Weiss <yoavweiss@chromium.org> > Reviewed-by: Nicolás Peña Moreno <npm@chromium.org> > Cr-Commit-Position: refs/heads/main@{#935133} Bug: 1260953 Change-Id: I00878689de95de38645195da81c6baf577d868a6 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3247071 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Owners-Override: Mikel Astiz <mastiz@google.com> Cr-Commit-Position: refs/heads/main@{#935350}
- Loading branch information
1 parent
6bbec86
commit 1ed6a86
Showing
10 changed files
with
0 additions
and
204 deletions.
There are no files selected for viewing
Binary file not shown.
This file was deleted.
Oops, something went wrong.
Binary file not shown.
27 changes: 0 additions & 27 deletions
27
largest-contentful-paint/animated/observe-animated-image-gif.tentative.html
This file was deleted.
Oops, something went wrong.
27 changes: 0 additions & 27 deletions
27
largest-contentful-paint/animated/observe-animated-image-webp.tentative.html
This file was deleted.
Oops, something went wrong.
29 changes: 0 additions & 29 deletions
29
largest-contentful-paint/animated/observe-animated-image.tentative.html
This file was deleted.
Oops, something went wrong.
30 changes: 0 additions & 30 deletions
30
largest-contentful-paint/animated/observe-cross-origin-animated-image.tentative.html
This file was deleted.
Oops, something went wrong.
30 changes: 0 additions & 30 deletions
30
largest-contentful-paint/animated/observe-cross-origin-tao-animated-image.tentative.html
This file was deleted.
Oops, something went wrong.
27 changes: 0 additions & 27 deletions
27
largest-contentful-paint/animated/observe-non-animated-image.tentative.html
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters