Skip to content

Commit

Permalink
Revert "Add a runtime enabled feature for removal of data: URL in SVG…
Browse files Browse the repository at this point in the history
…UseElement"

This reverts commit 23fdc0eb00c8597c2c74faee91b4a6a4e2296f3c.

Reason for revert: Not landing immediately, I want to do a manual try on GPU bots to confirm if this is the cause of an SVG test failure. See crbug.com/1406342

Original change's description:
> Add a runtime enabled feature for removal of data: URL in SVGUseElement
>
> This CL adds a runtime enabled feature and WPT for removal of data: URLs
> in in SVGUseElement.
> See: w3c/svgwg#901
>
> But: 1300195
> Change-Id: Ieab699fc167b254c65b92ed811756404dcc7c575
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4104249
> Reviewed-by: Mike West <mkwst@chromium.org>
> Commit-Queue: Jun Kokatsu <jkokatsu@google.com>
> Cr-Commit-Position: refs/heads/main@{#1090945}

Change-Id: I09bed766cad4afcf99e526af82d0736c39190de9
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
  • Loading branch information
Jonathan Ross authored and chromium-wpt-export-bot committed Jan 10, 2023
1 parent 8ff38c5 commit 498721b
Show file tree
Hide file tree
Showing 5 changed files with 2 additions and 30 deletions.
3 changes: 0 additions & 3 deletions svg/struct/reftests/support/red-rect.svg

This file was deleted.

12 changes: 0 additions & 12 deletions svg/struct/reftests/use-cross-origin.svg

This file was deleted.

7 changes: 0 additions & 7 deletions svg/struct/reftests/use-data-url.tentative.svg

This file was deleted.

6 changes: 0 additions & 6 deletions svg/struct/reftests/use-same-origin.svg

This file was deleted.

4 changes: 2 additions & 2 deletions svg/struct/scripted/use-load-error-events.tentative.html
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
promise_test(t => {
const svg = document.querySelector('svg');
const use = newUseElement();
const watcher = expectEvents(t, use, ['error']);
const watcher = expectEvents(t, use, ['load']);
const url = getUrl('existing-data');
svg.appendChild(use).setAttribute('href', url);
return watcher;
Expand Down Expand Up @@ -113,7 +113,7 @@
const url = getUrl('existing-data');
svg.appendChild(use).setAttribute('href', url);
t.step_timeout(() => use.setAttribute('href', '#local'));
return makeWatcher(svg, 'error', url);
return makeWatcher(svg, 'load', url);
}, document.title + ', external data: URL reference, existing, changed to local reference while loading');

promise_test(t => {
Expand Down

0 comments on commit 498721b

Please sign in to comment.