Skip to content

Commit

Permalink
Undo CSSTransitionDiscrete interpolation test changes
Browse files Browse the repository at this point in the history
Now that we are planning to add a new opt-in syntax for
CSSTransitionDiscrete, the test changes which I made for
CSSTransitionDiscrete will not eventually stick. Since these tests are
interop23 tracked, the other browsers would like them to be updated
ASAP.

I thought about also disabling the CSSTransitionDiscrete flag, which
would make this patch a lot cleaner, but that would break demos and
stuff people are working on so I decided against it.

This was asked for here:
#39871

CSSTransitionDiscrete opt in syntax:
w3c/csswg-drafts#8857

Change-Id: If28b7e9fc4fc0d6dc851e35007fd7614a9b497a0
  • Loading branch information
josepharhar authored and chromium-wpt-export-bot committed Jun 8, 2023
1 parent a61c760 commit 69c0adf
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions css/css-fonts/discrete-no-interpolation.html
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@
<script>
test_no_interpolation({
property: 'font-family',
from: 'initial',
to: 'c'
from: 'serif',
to: 'monospace'
});

test_no_interpolation({
Expand Down
2 changes: 1 addition & 1 deletion css/support/interpolation-testcommon.js
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@
target.style.setProperty(property, isNeutralKeyframe(from) ? '' : from);
},
nonInterpolationExpectations: function(from, to) {
return expectFlip(from, to, 0.5);
return expectFlip(from, to, -Infinity);
},
notAnimatableExpectations: function(from, to, underlying) {
return expectFlip(from, to, -Infinity);
Expand Down

0 comments on commit 69c0adf

Please sign in to comment.