Skip to content

Commit

Permalink
Remove pop-up test for unscopable popup attr
Browse files Browse the repository at this point in the history
There was a previous web compat issue with event handler attributes
calling functions called "popup()". As a result, we made the `popup`
attribute unscopable, so this would not break the web. However,
with the change of name to `popUp` for the IDL attribute, this
compat issue likely doesn't exist, for the same reasons that this
rename fixed the general compat issue [1].

This CL removes the test for unscopable. The [2] CL actually made
the attribute scopable.

[1] openui/open-ui#546
[2] https://chromium-review.googlesource.com/c/chromium/src/+/3954386

Bug: 1307772
Change-Id: I603e75338e1ccb925e6f145870fa6fecc68c61fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/3963911
Reviewed-by: Joey Arhar <jarhar@chromium.org>
Commit-Queue: Mason Freed <masonf@chromium.org>
Auto-Submit: Mason Freed <masonf@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1062228}
  • Loading branch information
mfreed7 authored and chromium-wpt-export-bot committed Oct 21, 2022
1 parent f1eadcd commit f91346d
Showing 1 changed file with 0 additions and 23 deletions.
23 changes: 0 additions & 23 deletions html/semantics/popups/popup-attribute-unscopable.tentative.html

This file was deleted.

0 comments on commit f91346d

Please sign in to comment.