Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/encoding/* are disabled in Chromium and WebKit #11015

Closed
zcorpan opened this issue May 15, 2018 · 4 comments
Closed

/encoding/* are disabled in Chromium and WebKit #11015

zcorpan opened this issue May 15, 2018 · 4 comments
Assignees
@zcorpan
Labels
encoding flaky

Comments

@zcorpan
Copy link
Member

zcorpan commented May 15, 2018

https://bocoup.github.io/wpt-disabled-tests-report/

/encoding/legacy-mb-tchinese/big5/big5-encode-form-errors-extBa.html

and

/encoding/legacy-mb-tchinese/big5/big5-encode-form-errors-extBb.html

should be split up, maybe similarly to how it was done in #10984
@zcorpan zcorpan self-assigned this May 15, 2018
@zcorpan
Copy link
Member Author

zcorpan commented May 15, 2018

Maybe also many other encoding tests.

zcorpan added a commit that referenced this issue May 15, 2018
@zcorpan
Split up big5-encode-form-errors-extB{a,b}.html with variant
8479ecd 
Fixes #11015.
zcorpan added a commit that referenced this issue May 15, 2018
@zcorpan
Split up big5-encode-form-errors-extB{a,b}.html with variant
7f04ea4 
Fixes #11015.
@zcorpan zcorpan mentioned this issue May 15, 2018
Merged
zcorpan added a commit that referenced this issue May 16, 2018
@zcorpan
Split up big5-encode-form-errors-extB{a,b}.html with variant
6af573f 
Fixes #11015.
zcorpan added a commit that referenced this issue May 16, 2018
@zcorpan
Split up big5-encode-form-errors-extB{a,b}.html with variant
cc994a7 
Fixes #11015.
zcorpan added a commit that referenced this issue May 24, 2018
@zcorpan
Split up big5-encode-form-errors-extB{a,b}.html with variant
169f8fb 
Fixes #11015.
@zcorpan zcorpan changed the title /encoding/legacy-mb-tchinese/big5/big5-encode-form-errors-extBa.html is disabled in Chromium and WebKit /encoding/* are disabled in Chromium and WebKit May 24, 2018
zcorpan added a commit that referenced this issue May 31, 2018
@zcorpan
Refactor and split up with variant all encoding tests
d6c29be 
Fixes #11015.
@Hexcles Hexcles reopened this May 31, 2018
@Hexcles
Copy link
Member

Hexcles commented Jun 1, 2018

Sorry, it seems like 1000 (code points?) per test is still too many for some tests.

It takes about 30 seconds to run each split test using content_shell (which is faster than full Chrome) on my workstation (which is faster than Chromium bots). The following tests still time out in Chromium:


 external/wpt/encoding/legacy-mb-japanese/euc-jp/eucjp-encode-href-errors-han.html?10001-10000
 external/wpt/encoding/legacy-mb-japanese/euc-jp/eucjp-encode-href-errors-hangul.html?10001-10000
 external/wpt/encoding/legacy-mb-japanese/shift_jis/sjis-encode-href-errors-han.html?10001-10000
 external/wpt/encoding/legacy-mb-tchinese/big5/big5-encode-href-errors-han.html?15001-16000
 external/wpt/encoding/legacy-mb-tchinese/big5/big5-encode-href-errors-han.html?16001-17000
 external/wpt/encoding/legacy-mb-tchinese/big5/big5-encode-href-errors-han.html?17001-18000
 external/wpt/encoding/legacy-mb-tchinese/big5/big5-encode-href-errors-han.html?18001-19000
 external/wpt/encoding/legacy-mb-tchinese/big5/big5-encode-href-errors-han.html?19001-20000
 external/wpt/encoding/legacy-mb-tchinese/big5/big5-encode-href-errors-han.html?20001-21000
 external/wpt/encoding/legacy-mb-tchinese/big5/big5-encode-href-errors-han.html?21001-22000
 external/wpt/encoding/legacy-mb-tchinese/big5/big5-encode-href-errors-han.html?22001-23000
 external/wpt/encoding/legacy-mb-tchinese/big5/big5-encode-href-errors-han.html?23001-last
 external/wpt/encoding/legacy-mb-tchinese/big5/big5-encode-href-errors-hangul.html?10001-10000

Also, there seems to be a bug in generating the indexes: the range "10001-10000" is probably wrong.

@zcorpan
Copy link
Member Author

zcorpan commented Jun 1, 2018

Thanks. Would 100 subtests be OK?

@zcorpan
Copy link
Member Author

zcorpan commented Jun 1, 2018

I managed to introduce a bug in some of the encoding tests (../../ranges.js should be ../../resources/ranges.js). Fixing.

zcorpan added a commit that referenced this issue Jun 1, 2018
@zcorpan
Split up encoding tests into buckets of 100 and fix bugs
b3a35be 
Bugs were introduced in d6c29be

* Some script paths were wrong
* A big5 test referenced eucjpEncoder instead of big5Encoder
* That big5 test also referenced encode-form-common.js instead of
  encode-href-common.js

Fixes #11015.
@zcorpan zcorpan mentioned this issue Jun 1, 2018
Merged
zcorpan added a commit that referenced this issue Jun 5, 2018
@zcorpan
Fix bugs in split-up encoding tests
5e0fea3 
Bugs were introduced in d6c29be

* Some script paths were wrong
* A big5 test referenced eucjpEncoder instead of big5Encoder
* That big5 test also referenced encode-form-common.js instead of
  encode-href-common.js

Fixes #11015.

Also add code to generate variants.
dhdavvie pushed a commit to dhdavvie/wpt that referenced this issue Jun 7, 2018
@zcorpan
Fix bugs in split-up encoding tests
905dc5b 
Bugs were introduced in d6c29be

* Some script paths were wrong
* A big5 test referenced eucjpEncoder instead of big5Encoder
* That big5 test also referenced encode-form-common.js instead of
  encode-href-common.js

Fixes web-platform-tests#11015.

Also add code to generate variants.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zcorpan zcorpan

Labels
encoding flaky
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zcorpan @Hexcles