Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TC runs can be successful when throwing Python exceptions #12876

Closed
gsnedders opened this issue Sep 6, 2018 · 0 comments
Closed

TC runs can be successful when throwing Python exceptions #12876

gsnedders opened this issue Sep 6, 2018 · 0 comments
Labels

Comments

@gsnedders
Copy link
Member

e.g. see https://tools.taskcluster.net/groups/JWdij6zCR4mWmw2V4ogQXA/tasks/Ll6F-MrBSOyvAtEG7viEgg/runs/0/logs/public%2Flogs%2Flive.log

INFO:manifest:Manifest downloaded
Traceback (most recent call last):
  File "./wpt", line 5, in <module>
    wpt.main()
  File "/home/test/web-platform-tests/tools/wpt/wpt.py", line 132, in main
    rv = script(*args, **kwargs)
  File "/home/test/web-platform-tests/tools/wpt/run.py", line 490, in run
    **kwargs)
  File "/home/test/web-platform-tests/tools/wpt/run.py", line 459, in setup_wptrunner
    channel = install.get_channel(kwargs["product"], kwargs["channel"])
  File "/home/test/web-platform-tests/tools/wpt/install.py", line 49, in get_channel
    channel = channel[browser]
KeyError: 'chrome_webdriver'
[taskcluster 2018-09-06 16:30:36.701Z] === Task Finished ===
[taskcluster 2018-09-06 16:30:38.432Z] Successful task run with exit code: 0 completed in 88.828 seconds

This shouldn't be a success.

@gsnedders gsnedders added the infra label Sep 6, 2018
gsnedders added a commit to gsnedders/web-platform-tests that referenced this issue Sep 6, 2018
@Ms2ger Ms2ger closed this as completed in d9e0776 Sep 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant