Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use --enable-experimental-web-platform-features for chrome-dev on Taskcluster #12908

Closed
foolip opened this issue Sep 9, 2018 · 4 comments
Closed

Comments

@foolip
Copy link
Member

foolip commented Sep 9, 2018

Results from Taskcluster are now being submitted to wpt.fyi staging:
https://staging.wpt.fyi/test-runs?labels=taskcluster,experimental

However, unlike the Buildbot runs, they don't have experimental web platform features enabled.

@jgraham
Copy link
Contributor

jgraham commented Sep 12, 2018

There's basically three possible ways to do this; either pass in --binary-arg=--enable[…] in the taskcluster shell script (although note that #12657 removes this), or enable it by default in wptrunner (maybe only if the channel is specified as dev), or in the wpt run frontend (again if the channel is specified as something nightly. For Firefox we effectively do this in wptrunner because we haven't yet split up the prefs we apply into "ones that are actually required to get reliable test results" from "ones that enable experimental features", but the constraints for Chrome are a little different.

@foolip
Copy link
Member Author

foolip commented Sep 12, 2018

@Hexcles, do you have preferences?

Any of those seem fine to me, with perhaps a slight preference for putting it in the Taskcluster setup, because dev without the extra features is a real thing and it'd be odd if it's not even possible to run that.

@jgraham
Copy link
Contributor

jgraham commented Sep 12, 2018

It is a real thing, but if Chromium developers are running wpt via wpt run, I assume the most useful default would be to run with experimental features enabled, matching wpt.fyi. Making them pass a flag like --binary-arg=--enable-experimental-web-platform-features to reproduce those results seems unfriendly.

Another options is to add --chrome-experimental and --no-chrome-experimental flags in wptrunner and default to enabled if no specific flag is passed and the channel is dev, or something).

@jugglinmike
Copy link
Contributor

gh-10452 proposes a generic flag that could enable experimental features for any browser

Hexcles added a commit that referenced this issue Sep 14, 2018
This change unconditionally adds the
"--enable-experimental-web-platform-features" flag to Chrome Dev, as we
believe most browser engineers would like to have these features enabled
if they are testing Chrome Dev, and it would make the default behaviour
more aligned with Blink layout tests. We may add a flag to explicitly
disable this in the future upon requests.

Fixes #12908.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants