-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only lint files that have changed in ci_lint.sh #6136
Comments
The way I discussed doing this with gsnedders is to cache the lint status with the file hash and not check files that haven't changed for lints that are based purely on the file contents. Travis can store cached artifacts. I'm not sure what generating a manifest only for certain files would look like, but my way means you don't need to ask the VCS which files changed. |
The manifest is used to determine what lint steps are run, right? I was thinking pass some command line arguments so that the manifest only includes a few files, those that are needed. Or, the manifest itself could be cached, we've done something like that in Chromium to get around the long build times for it. |
FWIW I have a branch that implements a simple version of this. Cuts the lint time pretty dramatically, but it depends on unmerged things in #6237 |
Erm, make that #6421 |
We merged this fix. |
We are currently generating the whole manifest and linting all files in ci_lint.sh. This takes over 2 minutes on my desktop machine, and is probably much slower still on Travis.
Everything that needs to happen should be possible in <1 second for a typical PR:
@bobholt linked to a discussion with @jgraham in http://logs.glob.uno/?c=w3%23testing&s=26+May+2017&e=26+May+2017
Do either of you know how long it currently takes on Travis in a typical case?
The text was updated successfully, but these errors were encountered: