-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add wpt frontend for commands #6421
Conversation
Firefox (nightly) |
Sauce (safari) |
Chrome (unstable) |
Sauce (MicrosoftEdge) |
This looks like it's still a work-in-progress with (since the build's not passing). Overall, I like how this simplifies the component modules. I left a couple of line comments for things that jumped out at me in this revision, but am pretty much 👍 as long as the builds work. I'd like to see a sample flakey test run with this before merging. Reviewed 31 of 31 files at r1. tools/browserutils/install.py, line 18 at r1 (raw file):
This doesn't account for the tools/wpt/run.py, line 18 at r1 (raw file):
Unresolved merge conflict that may be causing some errors. Comments from Reviewable |
a092c62
to
461b69c
Compare
Yeah, this isn't done, just pushing it here for a little visibility. |
e08abe7
to
99216ed
Compare
99216ed
to
1381a3b
Compare
How does this relate to #6237? |
2da5be0
to
73b8a53
Compare
This is more stuff on top of that one. |
847c430
to
56827ed
Compare
This is intended to provide a single point of entry for all wpt commands and make it easier to share infrastructure like virtual environments. Commands are defined via a commands.json file in the directory containing the command. This isi still pretty rough, but it basically works.
e68ab8c
to
7f1f761
Compare
👍 when the tests pass. @gsnedders do you have any interest in taking another pass at this? Reviewed 1 of 35 files at r1, 2 of 29 files at r3, 3 of 3 files at r4, 3 of 3 files at r5. tools/wpt/install.py, line 18 at r1 (raw file): Previously, bobholt (Bob Holt) wrote…
LGTM Comments from Reviewable |
0e2a8fb
to
8405c77
Compare
8405c77
to
0d63d22
Compare
df199d2
to
e9fb7df
Compare
@bobholt As I said to @jgraham an hour ago, I don't think there's much worth is spending more time on reviewing this; my quick skim before didn't really find anything notable, and I doubt I'll find much more than what you have… though I'll inevitable find stuff in six months regardless of whether I review it now or not. :) |
Reviewed 15 of 35 files at r1, 4 of 12 files at r2, 22 of 29 files at r3, 3 of 3 files at r4, 1 of 3 files at r5, 10 of 10 files at r6. Comments from Reviewable |
This change is