Get rid of last web-platform.test, make host_ip always present #10078
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build PASSEDStarted: 2018-03-19 15:39:50 View more information about this build on: |
|
Reviewed 3 of 3 files at r1, 3 of 3 files at r2, 1 of 1 files at r3. tools/serve/serve.py, line 679 at r1 (raw file):
This seems very confusing. I don't know what the better option is, but I'm pretty sure this is going to cause trouble. Comments from Reviewable |
jgraham
requested changes
Mar 19, 2018
| @@ -168,7 +168,8 @@ def __init__(self, server_address, request_handler_cls, | |||
| Server.config = config | |||
| else: | |||
| self.logger.debug("Using default configuration") | |||
| Server.config = {"host": server_address[0], | |||
| Server.config = {"browser_host": server_address[0], | |||
There was a problem hiding this comment.
This doesn't seem very meaningful, to put browser_host and server_host and set them to o the same value.
jgraham
approved these changes
Mar 19, 2018
gsnedders
force-pushed
the
host_ip_always
branch
from
dcb0aa7 to
d2bf9c1
Compare
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Apr 5, 2018
This roll is mainly to include web-platform-tests/wpt#10323, which fixes a bug that `wpt manifest` would fail when the local manifest is invalid. wpt.config.json is changed to accomodate: web-platform-tests/wpt#9998 web-platform-tests/wpt#10078 Bug: 822041 Change-Id: I074afd90e32db299fc6f58b870f9b72576fab225 Reviewed-on: https://chromium-review.googlesource.com/997764 Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#548584}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is