Generic executor that uses WebDriver protocol directly #10197
Conversation
Build BROKENStarted: 2018-04-03 18:53:33 Failing Jobs
View more information about this build on: |
|
@gsnedders @jgraham PTAL :) |
| @@ -51,7 +53,15 @@ def executor_kwargs(test_type, server_config, cache_manager, run_info_data, | |||
| capabilities["chromeOptions"]["excludeSwitches"] = ["enable-automation"] | |||
| if test_type == "wdspec": | |||
| capabilities["chromeOptions"]["w3c"] = True | |||
| executor_kwargs["capabilities"] = capabilities | |||
|
|
|||
| if __wptrunner__["executor"]["testharness"] == "WebDriverTestharnessExecutor" \ | |||
There was a problem hiding this comment.
Don't use line contnuation characters.
| @@ -42,6 +42,11 @@ def _set(self, key, secs): | |||
| timeouts = self.session.send_session_command("POST", "timeouts", body) | |||
| return None | |||
|
|
|||
| def set_w3c(self, timeout, secs): | |||
| body = {"type": timeout, "ms": secs * 1000} | |||
There was a problem hiding this comment.
Add this into the webdriver client rather than here.
There was a problem hiding this comment.
Not sure what you mean, this is in tools/webdriver/webdriver/client.py which is the webdriver client?
| return self.protocol.is_alive() | ||
|
|
||
| def do_test(self, test): | ||
| self.logger.info("Test requires OS-level window focus") |
There was a problem hiding this comment.
That's only really true for Chrome, and maybe isn't true anymore.
There was a problem hiding this comment.
Guilty of copy paste here. Also I'm not sure if its true anymore either. I will delete this.
| @@ -3,6 +3,8 @@ | |||
| from ..executors import executor_kwargs as base_executor_kwargs | |||
| from ..executors.executorselenium import (SeleniumTestharnessExecutor, | |||
| SeleniumRefTestExecutor) | |||
| from ..executors.executorwebdriver import (WebDriverTestharnessExecutor, | |||
| WebDriverRefTestExecutor) | |||
| capabilities["chromeOptions"]["w3c"] = True | ||
| always_match = {"alwaysMatch": capabilities} | ||
| executor_kwargs["capabilities"] = always_match | ||
|
|
| executor_kwargs["capabilities"] = capabilities | ||
|
|
||
| if __wptrunner__["executor"]["testharness"] == "WebDriverTestharnessExecutor" \ | ||
| or __wptrunner__["executor"]["reftest"] == "WebDriverRefTestExecutor": |
There was a problem hiding this comment.
This isn't really a swappable thing, so I wonder what the intent here is? Per the current design you would have to make this a different product like chrome-webdriver.
There was a problem hiding this comment.
I didn't consider that for some reason... that sounds like a cleaner way to do it. Good suggestion :)
The motivation behind this is to give the option to not use Selenium with WebDriver. There are multiple reasons one might want to do this:
This change is