Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bluetooth: FakeBluetoothChooser impl. #10224

Merged
merged 1 commit into from
Mar 29, 2018
Merged

Commits on Mar 29, 2018

  1. bluetooth: FakeBluetoothChooser impl.

    Implements the interfaces that FakeBluetoothChooser overrides. The
    mojom::FakeBluetoothChooser overrides are implemented by running
    |event_handler_| with the appropriate arguments. The BluetoothChooser
    overrides do nothing at the moment, since the base class is only meant
    to update the chooser user interface.
    
    This change also begins to partially convert a Bluetooth chooser test to test
    the interface and deletes the temporary tests that were created to test this
    API.
    
    This change reverts commit 42624492cd5e80855f1dd3a5a8146b258def2c2a, which
    reverted the original change. The original change caused the
    new-scan-device-added.html test to fail because of a Mojo validation error
    resulting from not updating the
    third_party/.../external/wpt/resources/chromium/fake_bluetooth_chooser.mojom.js
    file needed by the test.
    
    Bug: 719827, 719826, 824704, 826787
    Change-Id: I5e5cce7e809b4d71216c2d074a417ea822d5e527
    Reviewed-on: https://chromium-review.googlesource.com/985195
    Commit-Queue: Ovidio Henriquez <odejesush@chromium.org>
    Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
    Reviewed-by: Daniel Cheng <dcheng@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#546729}
    odejesush authored and chromium-wpt-export-bot committed Mar 29, 2018
    Configuration menu
    Copy the full SHA
    4d19be4 View commit details
    Browse the repository at this point in the history