HTML/events/beforeunload - respect preventDefault(). #12221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jul 29, 2018
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1154225
branch
5 times, most recently
from
1be6b44 to
292c62a
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1154225
branch
3 times, most recently
from
fad4ebd to
3471132
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1154225
branch
3 times, most recently
from
c6fff44 to
68f85b6
Compare
An existing web-platform-test was enhanced to make sure the preventDefault only (or combined) cases work. Added many layout tests (due to the lack of web-platform-tests APIs for handling beforeunload alert) for most of the intricacies of beforeunload. Bug: 866818 Change-Id: I35c27cee1f71a4e4d10331d3451e0a36b9db684d
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1154225
branch
from
68f85b6 to
3dadc0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An existing web-platform-test was enhanced to make sure
the preventDefault only (or combined) cases work.
Added many layout tests (due to the lack of
web-platform-tests APIs for handling beforeunload alert)
for most of the intricacies of beforeunload.
Bug: 866818
Change-Id: I35c27cee1f71a4e4d10331d3451e0a36b9db684d
Reviewed-on: https://chromium-review.googlesource.com/1154225
WPT-Export-Revision: 2c4d10c3435bc0d493b3dbe0de42d7f41f8da0e8