-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AZZ replaced with A9Z #13178
base: master
Are you sure you want to change the base?
AZZ replaced with A9Z #13178
Conversation
@frivoal is the appropriate and best person to review and merge your pull request, kritisingh1. It is really preferable that Florian reviews and merges this. Florian is author of the css-contain spec and author of the quote-scoping-002 test. |
Thanks. We should indeed fix the difference between the test and the reference. However, it seems to me that the reference is the correct one, not the test, so they should both be fixed to read From the spec:
There's only 1 Do you think I am getting this wrong? |
I have examined section 12.2 ('content' property) and section 12.3.1 ('quotes' property) and this is much harder than I thought. The quote-scoping-002 test as edited does not declare I propose these 2 test replacements (otherwise, additions): |
I think you get this correct. What "bugs" me is that the span's close-quote value of the content property does not require 'contain: style' anyway in order to be scoped to the element's subtree ... |
Argh.... I am still confused. I need to understand the note from the spec you quoted... |
I do think it would be fairly unusual for a piece of content to be marked-up / styled this way, but tests don't need to be semantically interesting, merely to be correct. With the markup as it is, the result is defined to be AZZ.
These two seem correct, but I don't think they're useful. Unless I misunderstand something, they would work just as well if you had no containment.
Basically,
The first effect is not at all changed by style containment. The second effect is:
That's kind of the point of the test. Outside of the subtree, there is one open-quote, one close-quote, so they respectively generate and |
Fixes #13066
@TalbotG please review. Thanks!