-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test Location sans browsing context #13435
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed for test structure and general reasonableness of what is being asserted, but please name .tentative.
if this is merged before the spec change. (Doing that might make it easier to see cross-browser results.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests seem good but I have a readability improvement I'd really like to see if possible :)
return loc; | ||
} | ||
|
||
[ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is pretty hard to read. It's more work for you but I'd suggest
[
{
prop: "href",
expected: "about:blank",
valuesToTry: ["https://example.com/", "/", "http://test:test/", "test test", "test:test", "chrome:fail"]
},
...
}
Previously, the various pieces of spec text here assumed that a browsing context always existed. Tests: web-platform-tests/wpt#13435. Fixes #3959.
Previously, the various pieces of spec text here assumed that a browsing context always existed. Tests: web-platform-tests/wpt#13435. Fixes whatwg#3959.
Previously, the various pieces of spec text here assumed that a browsing context always existed. Tests: web-platform-tests/wpt#13435. Fixes whatwg#3959.
For whatwg/html#3959.