[css-text] Rework some tests to avoid anti aliasing issues #13510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
fantasai,
hakatashi,
kojiishi,
nox,
plinss and
r12a
|
@frivoal looks like there are conflicts. I tried to resolve them but they're not trivial enough. Can you resolve and I'll do light review? |
These tests used to have anti aliasing artefacts. A previous commit (cf14912) solved that, at the expense of making the tests impractical to review manually, and no longer self descriptive. This change fixes that, while keeping the tests robust to anti aliasing artefacts.
frivoal
force-pushed
the
antialiasing-bug
branch
from
b9a70a0 to
5df4951
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in https://bugzilla.mozilla.org/show_bug.cgi?id=1498698#c1
The tests introduced in #11373
fail due to anti aliasing issues that let some red show through at the edges
even when things are correctly aligned and the red should be hidden.
Rework these tests to avoid the problem.