-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[css-backgrounds] Initial values and inheritance #13688
Merged
ewilligers
merged 2 commits into
web-platform-tests:master
from
ewilligers:backgrounds-inheritance
May 6, 2019
Merged
[css-backgrounds] Initial values and inheritance #13688
ewilligers
merged 2 commits into
web-platform-tests:master
from
ewilligers:backgrounds-inheritance
May 6, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@fantasai Please review |
ewilligers
force-pushed
the
backgrounds-inheritance
branch
from
November 5, 2018 18:17
b5a4754
to
f938297
Compare
This was referenced Jan 9, 2019
@dbaron Please review |
dbaron
approved these changes
May 6, 2019
css/css-backgrounds/inheritance.html
Outdated
column-rule-width: medium; | ||
} | ||
#container { | ||
border-style: solid; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add a comment here and 3 lines below about border-width
style... which I assume is what this is about... or whatever it is about?
Test that CSS Backgrounds and Borders properties have the initial values given in the spec. None of the properties inherit. https://drafts.csswg.org/css-backgrounds/ Identified bugs: repeated keywords in initial value https://bugzilla.mozilla.org/show_bug.cgi?id=1501261 border-image initial values https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/19381805/ box-shadow serialization order https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/19381950/ border-image-outset initial value https://bugs.chromium.org/p/chromium/issues/detail?id=898203
ewilligers
force-pushed
the
backgrounds-inheritance
branch
from
May 6, 2019 07:40
f938297
to
1401ab1
Compare
loly89
pushed a commit
to loly89/wpt
that referenced
this pull request
May 6, 2019
…13688) * [css-backgrounds] Initial values and inheritance Test that CSS Backgrounds and Borders properties have the initial values given in the spec. None of the properties inherit. https://drafts.csswg.org/css-backgrounds/ Identified bugs: repeated keywords in initial value ~https://bugzilla.mozilla.org/show_bug.cgi?id=1501261~ border-image initial values https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/19381805/ box-shadow serialization order https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/19381950/ border-image-outset initial value https://bugs.chromium.org/p/chromium/issues/detail?id=898203
marcoscaceres
pushed a commit
that referenced
this pull request
Jul 23, 2019
* [css-backgrounds] Initial values and inheritance Test that CSS Backgrounds and Borders properties have the initial values given in the spec. None of the properties inherit. https://drafts.csswg.org/css-backgrounds/ Identified bugs: repeated keywords in initial value ~https://bugzilla.mozilla.org/show_bug.cgi?id=1501261~ border-image initial values https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/19381805/ box-shadow serialization order https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/19381950/ border-image-outset initial value https://bugs.chromium.org/p/chromium/issues/detail?id=898203
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test that CSS Backgrounds and Borders properties have the initial
values given in the spec. None of the properties inherit.
https://drafts.csswg.org/css-backgrounds/
Identified bugs:
repeated keywords in initial value
https://bugzilla.mozilla.org/show_bug.cgi?id=1501261border-image initial values
https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/19381805/
box-shadow serialization order
https://developer.microsoft.com/en-us/microsoft-edge/platform/issues/19381950/
border-image-outset initial value
https://bugs.chromium.org/p/chromium/issues/detail?id=898203