Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UCS-4 support check for Python in build-css-testsuites.sh #13696

Merged
merged 2 commits into from
Oct 24, 2018

Conversation

qiuzhong
Copy link
Contributor

CSS test suite build system requires Python UCS-4 support.
Add this check in css/build-css-testsuites.sh.
Fix: #5504

@wpt-pr-bot
Copy link
Collaborator

There are no reviewers for this pull request. Please reach out on W3C's irc server (irc.w3.org, port 6665) on channel #testing (web client) to get help with this. Thank you!

CSS test suite build system requires Python UCS-4 support.
Add this check in css/build-css-testsuites.sh.
Fix: web-platform-tests#5504
Copy link
Member

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest a comment to add, otherwise looks good to me. I notice the Python on my Mac doesn't support UCS-4.

css/build-css-testsuites.sh Show resolved Hide resolved
Co-Authored-By: qiuzhong <zhongx.qiu@intel.com>
@foolip foolip requested a review from gsnedders October 24, 2018 05:58
@foolip
Copy link
Member

foolip commented Oct 24, 2018

@gsnedders can you sign off too?

@gsnedders gsnedders merged commit 32150f7 into web-platform-tests:master Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants