Make Server-Timing tests more resilient #13789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
deniak,
dontcallmedom,
gsnedders,
igrigorik and
zqzhang
yoavweiss
approved these changes
Oct 30, 2018
| @@ -7,7 +7,8 @@ | |||
| <head> | |||
| <meta charset='utf-8' /> | |||
| <script src="/resources/testharness.js"></script> | |||
| <script src='/resources/testharnessreport.js'></script> | |||
| <script src="/resources/testharnessreport.js"></script> | |||
| <script src="/common/performance-timeline-utils.js"></script> | |||
There was a problem hiding this comment.
Including this once seems enough :)
There was a problem hiding this comment.
whoops! thx - fixed.
gsnedders
reviewed
Nov 2, 2018
|
|
||
| function delayedLoadListener(callback) { | ||
| window.addEventListener('load', function() { | ||
| // TODO(cvazac) Remove this setTimeout when spec enforces sync entries. |
There was a problem hiding this comment.
Can you file a bug for this to track it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per spec, the performance timeline is not guaranteed to have entries for blocking resources during
loadcallbacks - which has led to intermittent failures. AddingsetTimeoutof zero should clean those up.