-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename generateOffer to generateDataChannelOffer and remove use of legacy optionsRename generateOffer to generateDataChannelOffer and remove use of legacy options #13893
Merged
youennf
merged 2 commits into
web-platform-tests:master
from
youennf:reduce-offerToReceive
Nov 4, 2018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
agouaillard,
alvestrand,
dontcallmedom,
guidou,
henbos,
phoglund,
rwaldron and
snuggs
November 4, 2018 02:28
alvestrand
approved these changes
Nov 4, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch that generateOffer() is only used to generate data channel offers!
Short helpers are good helpers.
soareschen
requested changes
Nov 4, 2018
soareschen
approved these changes
Nov 4, 2018
Firefox bot issue is probably unrelated, merging. |
youennf
added a commit
to youennf/web-platform-tests
that referenced
this pull request
Nov 4, 2018
youennf
added a commit
to youennf/web-platform-tests
that referenced
this pull request
Nov 4, 2018
youennf
added a commit
to youennf/web-platform-tests
that referenced
this pull request
Nov 4, 2018
youennf
added a commit
that referenced
this pull request
Nov 4, 2018
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Nov 14, 2018
…rm-tests/wpt#13893, a=testonly Automatic update from web-platform-testsFix regressions introduced in web-platform-tests/wpt#13893 (#13908) -- wpt-commits: f1373b111b40f43398da4a7ecf01a44453ef7564 wpt-pr: 13908
staktrace
pushed a commit
to staktrace/gecko
that referenced
this pull request
Nov 15, 2018
…rm-tests/wpt#13893, a=testonly Automatic update from web-platform-testsFix regressions introduced in web-platform-tests/wpt#13893 (#13908) -- wpt-commits: f1373b111b40f43398da4a7ecf01a44453ef7564 wpt-pr: 13908
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-comments-removed
that referenced
this pull request
Oct 3, 2019
…rm-tests/wpt#13893, a=testonly Automatic update from web-platform-testsFix regressions introduced in web-platform-tests/wpt#13893 (#13908) -- wpt-commits: f1373b111b40f43398da4a7ecf01a44453ef7564 wpt-pr: 13908 UltraBlame original commit: 8e32b8bc8fc1844bb6476e94c9c5be5e579d009f
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Oct 3, 2019
…rm-tests/wpt#13893, a=testonly Automatic update from web-platform-testsFix regressions introduced in web-platform-tests/wpt#13893 (#13908) -- wpt-commits: f1373b111b40f43398da4a7ecf01a44453ef7564 wpt-pr: 13908 UltraBlame original commit: 8e32b8bc8fc1844bb6476e94c9c5be5e579d009f
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Oct 3, 2019
…rm-tests/wpt#13893, a=testonly Automatic update from web-platform-testsFix regressions introduced in web-platform-tests/wpt#13893 (#13908) -- wpt-commits: f1373b111b40f43398da4a7ecf01a44453ef7564 wpt-pr: 13908 UltraBlame original commit: 8e32b8bc8fc1844bb6476e94c9c5be5e579d009f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.