-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[streams] Refactor to multi-global test format #14172
[streams] Refactor to multi-global test format #14172
Conversation
Hmm, I guess I should have run
I guess we can no longer use |
Presumably you moved files and a rule in lint.whitelist that previously matched now doesn't. But it would be good to remove the setTimeout use if possible. |
@jgraham You're right, the paths changed, so I had to update the whitelist. I'll see if switching to |
Good news, it just works! 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
You no longer need the call to done()
at the bottom of each js file. But it's not doing any harm.
Something went wrong with Taskcluster for Firefox Nightly? 😕 Looks like
|
I closed and reopened as that's the only way to retrigger taskcluster until https://bugzilla.mozilla.org/show_bug.cgi?id=1509083 is fixed (reruns have complex semantics in general and people tried to deprecate them as a result, but they're what we need in this case, so…). |
45185ed
to
7480e68
Compare
Rebased to fix conflicts with a51c2df. |
With web-platform-tests/wpt#14172 wpt streams tests now use the standard *.any.js format for multi-platform tests. As a result all the test filenames have changed and there are a large number of obsolete *-expected.txt files left behind. Delete them. Change-Id: Ia5ce3b89e3866745d19bd1d521c7fb731342e024 Reviewed-on: https://chromium-review.googlesource.com/c/1350552 Reviewed-by: Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#611036}
This changes all tests for streams to the multi-global
.any.js
format, and removes the old test wrappers.Previously, the streams tests had to use custom test wrappers, because one of the tools used by the spec authors did not support auto-generating the necessary test boilerplate. This has been fixed in domenic/wpt-runner#12, so we can finally migrate the tests to the standard format. 😄
Fixes #10597