Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eme] Check if encryption scheme is supported #14383

Merged

Conversation

jrummell-chromium
Copy link
Contributor

In [1] there is a proposal to add the ability for querying the encryption
schemes supported by the CDM to MediaKeySystemConfiguration. Adding a test
to check this.

[1] https://github.com/WICG/encrypted-media-encryption-scheme/blob/master/explainer.md

In [1] there is a proposal to add the ability for querying the encryption
schemes supported by the CDM to MediaKeySystemConfiguration. Adding a test
to check this.

[1] https://github.com/WICG/encrypted-media-encryption-scheme/blob/master/explainer.md
},
function error() {
// CDM does not support "encryptionScheme". Test should
// still pass.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: does this fit in one line?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was done by the Chromium formatter. Fixed.

Copy link

@xhwang-chromium xhwang-chromium left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm % nit

@foolip foolip merged commit 01e59d3 into web-platform-tests:master Jan 24, 2019
@jrummell-chromium jrummell-chromium deleted the check_encryption_scheme branch February 8, 2019 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants