Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3 de-linting #14973

Merged
merged 1 commit into from
Jan 22, 2019
Merged

python3 de-linting #14973

merged 1 commit into from
Jan 22, 2019

Conversation

refack
Copy link
Contributor

@refack refack commented Jan 21, 2019

xrange give a very very slight memory (premature?) optimization in python2, but is incompatible with python3

Refs: https://docs.python.org/3/whatsnew/3.0.html#views-and-iterators-instead-of-lists

@refack
python3 de-linting
80f5b5a 
xrange give a very very slight memory optimization but is incompatible with python3
annevk
annevk approved these changes Jan 21, 2019
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy with this provided it works in Python 2. Performance shouldn't be a big deal given the small number.

This was referenced Jan 21, 2019
Merged
Merged
@thefourtheye
Copy link

The taskcluster hasn't responded yet. Is this normal?

@annevk
Copy link
Member

annevk commented Jan 22, 2019

No, I asked @jgraham on IRC to look into it.

@thefourtheye
Copy link

Thanks a lot @annevk :-)

@gsnedders
Copy link
Member

That's… weird. Presumably some request failing to get through in some direction. :(

Let's close/reopen to re-trigger it, even though really this should be safe enough just to merge.

@gsnedders gsnedders closed this Jan 22, 2019
@gsnedders gsnedders reopened this Jan 22, 2019
@gsnedders gsnedders merged commit e4e6eee into web-platform-tests:master Jan 22, 2019
@thefourtheye
Copy link

really this should be safe enough just to merge.

I totally agree.

Thanks @annevk and @gsnedders 🙂

@refack refack deleted the patch-1 branch January 22, 2019 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk approved these changes

@thefourtheye thefourtheye thefourtheye approved these changes

@inexorabletash inexorabletash Awaiting requested review from inexorabletash

Assignees

@annevk annevk

Labels
encoding
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@refack @thefourtheye @annevk @gsnedders @wpt-pr-bot