Add sectioning tests. #1538
Add sectioning tests. #1538
Conversation
| onerror = "foobar = 4;" | ||
| onafterprint = "foobar = 5;" | ||
| onbeforeprint = "foobar = 6;" | ||
| onbeforeunload = "foobar = 7;"" |
There was a problem hiding this comment.
Looks like there's a syntax error here.
wpt-pr-bot
requested review from
annevk,
domenic,
jdm,
jgraham,
zcorpan and
zqzhang
|
I suspect they're all still valid and as useful as they were when first submitted. |
|
@Ms2ger can you rebase to retrigger Travis+Taskcluster. I can review. |
….body-getter.html.
|
CI passes now. |
| assert_regexp_match(strCheck, regEx, "document.body." + strAttr + ":"); | ||
|
|
||
| } else { | ||
| assert_equals(document.body[strAttr], funcExpected, "document.body." + strAttr + ":"); |
There was a problem hiding this comment.
This and all other assert_equals involving funcExpected are broken because it assumes the function object survives the mirroring, but it does not. The spec for this is https://html.spec.whatwg.org/#window-reflecting-body-element-event-handler-set and from that I found existing tests:
https://wpt.fyi/results/html/webappapis/scripting/events/event-handler-attributes-body-window.html?label=experimental
https://wpt.fyi/results/html/webappapis/scripting/events/event-handler-attributes-window-body.html?label=experimental
https://wpt.fyi/results/html/webappapis/scripting/events/event-handler-attributes-windowless-body.html?label=experimental
I'll delete this test from the PR and keep reviewing.
Redundant with tests in html/webappapis/scripting/events.
| <meta charset="utf-8"> | ||
| <title>Body Element</title> | ||
| <link rel="author" title="dzenana" href="mailto:dzenana.trenutak@gmail.com"> | ||
| <link rel="help" href="http://www.w3.org/html/wg/drafts/html/CR/single-page.html#the-body-element"> |
There was a problem hiding this comment.
The spec for this and part2 is the places that reference https://html.spec.whatwg.org/#determining-the-target-of-an-event-handler. The model is that setting/getting the content and IDL attribute redirects to the window object, as opposed to the event target order being tweaked during event dispatch.
part1 and part2 all pass on Chrome, Edge, Firefox and Safari, except for part1 on Edge. I'm pretty sure that's covered by the Edge failures in https://wpt.fyi/results/html/webappapis/scripting/events/event-handler-attributes-body-window.html?label=stable&aligned=true.
With this covered in html/webappapis/scripting/events/, I'll delete these too.
|
Alright, so a pretty clear pattern is emerging here. The tests are all about event handlers on the body element, quite verbose and slow to run. For the cases I've looked closely at I've concluded that the exists tests are better. I've tried running most of the tests in all browsers and while I've spotted some differences, those too seem to be covered by existing tests. So, I don't think there's value in anyone studying in detail if there is some delta of test coverage provided by these tests but not existing ones. I'll just close the PR, but if anyone feels differently please reopen and review away :) |
No description provided.