Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML: opener of a Window sans browsing context #15461

Merged
merged 2 commits into from
Feb 22, 2019

Conversation

annevk
Copy link
Member

@annevk annevk commented Feb 19, 2019

I'm not going to file new bugs for Chrome and Safari failures as they're variants of the one I already filed/found for embedded-opener.html in the same directory.

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but could do more, I think?

<script src=/resources/testharnessreport.js></script>
<div id=log></div>
<iframe name=matchesastring></iframe>
<script>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also test a window.close()ed popup?

@annevk
Copy link
Member Author

annevk commented Feb 22, 2019

I'll merge this and create a new PR for that.

@annevk annevk merged commit ad1ab06 into master Feb 22, 2019
@annevk annevk deleted the annevk/removed-window-opener branch February 22, 2019 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants