Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ FeaturePolicy ] downloads-without-user-activation #16218

Merged
merged 1 commit into from
Apr 17, 2019

Conversation

chromium-wpt-export-bot
Copy link
Collaborator

@chromium-wpt-export-bot chromium-wpt-export-bot commented Apr 2, 2019

The CL implements a new feature policy hidden behind the flag
FeaturePolicyForSandbox. The policy is the feature policy counterpart to
the sandbox flag 'allow-downloads-without-user-activation'. This policy
is used to help migrate sandbox flags implementation on top of feature
policies.

PA: w3c/webappsec-permissions-policy#289

TBR=alexmos@chromium.org

Bug: 812381
Change-Id: I234bb0486313ab350827315843db22525c2ceaac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538966
Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651773}

Copy link
Collaborator

@wpt-pr-bot wpt-pr-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already reviewed downstream.

@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1538966 branch 9 times, most recently from e6caf75 to 154756f Compare April 9, 2019 18:51
@chromium-wpt-export-bot chromium-wpt-export-bot force-pushed the chromium-export-cl-1538966 branch 5 times, most recently from 4886542 to 83af659 Compare April 16, 2019 15:49
The CL implements a new feature policy hidden behind the flag
FeaturePolicyForSandbox. The policy is the feature policy counterpart to
the sandbox flag 'allow-downloads-without-user-activation'. This policy
is used to help migrate sandbox flags implementation on top of feature
policies.

PA: w3c/webappsec-permissions-policy#289

TBR=alexmos@chromium.org

Bug: 812381
Change-Id: I234bb0486313ab350827315843db22525c2ceaac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538966
Reviewed-by: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Ian Clelland <iclelland@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#651773}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants