Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTML: mark typemustmatch historical #16656

Merged
merged 2 commits into from
May 3, 2019
Merged

HTML: mark typemustmatch historical #16656

merged 2 commits into from
May 3, 2019

Conversation

annevk
Copy link
Member

@annevk annevk commented May 3, 2019

Apart from Firefox nobody adopted this and it creates a smallish cross-origin leak.

@annevk
HTML: mark typemustmatch historical
9be310d 
Apart from Firefox nobody adopted this and it creates a smallish cross-origin leak.
@wpt-pr-bot wpt-pr-bot added the html label May 3, 2019
@annevk annevk mentioned this pull request May 3, 2019
Merged
3 tasks
@Ms2ger
Copy link
Contributor

Ms2ger commented May 3, 2019

Go ahead and remove the line in webdriver/tests/get_element_attribute/get.py

andreastt
andreastt approved these changes May 3, 2019
View reviewed changes
Copy link
Member

@andreastt andreastt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

webdriver/ bit is obviously fine. 👍🏻

@zcorpan
Copy link
Member

zcorpan commented May 3, 2019

Is interfaces/html.idl synced automatically?

@annevk
Copy link
Member Author

annevk commented May 3, 2019

Yeah, it should be, once the HTML change lands.

@annevk annevk merged commit 631acf0 into master May 3, 2019
@annevk annevk deleted the annevk/typemustmatch branch May 3, 2019 12:16
annevk added a commit to whatwg/html that referenced this pull request May 3, 2019
@annevk
Remove <object typemustmatch>
2606f90 
It did not get wide enough adoption and causes a minor cross-origin leak.

See https://lists.w3.org/Archives/Public/public-whatwg-archive/2011Jun/0144.html for its introduction and https://github.com/xsleaks/xsleaks/wiki/Browser-Side-Channels#object-typemustmatch for the leak.

Tests: web-platform-tests/wpt#16656.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcorpan zcorpan zcorpan approved these changes

@andreastt andreastt andreastt approved these changes

@domenic domenic Awaiting requested review from domenic

@foolip foolip Awaiting requested review from foolip

@jdm jdm Awaiting requested review from jdm

@jgraham jgraham Awaiting requested review from jgraham

@zqzhang zqzhang Awaiting requested review from zqzhang

@AutomatedTester AutomatedTester Awaiting requested review from AutomatedTester

@mjzffr mjzffr Awaiting requested review from mjzffr

@shs96c shs96c Awaiting requested review from shs96c

@whimboo whimboo Awaiting requested review from whimboo

Assignees

@zcorpan zcorpan

Labels
html webdriver wg-testing_browser
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@annevk @Ms2ger @zcorpan @andreastt @wpt-pr-bot