Add support for overscroll-behavior logical longhands #16890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
May 16, 2019
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1614026
branch
from
35b0196
to
d8c7b82
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1614026
branch
from
d8c7b82
to
f34465a
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1614026
branch
from
f34465a
to
b7d12c6
Compare
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1614026
branch
2 times, most recently
from
38e8c30
to
ec1d0b2
Compare
Flow relative longhands have been added to overscroll-behavior specification [1]. This CL implements the relevant css parsing and matching tests. minor change: collapse all overscrollBehavior related case statements in parser fast path. intent-to-ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/V86fOkIaEQA/JydSaafqBwAJ [1] https://drafts.csswg.org/css-overscroll-behavior-1/#overscroll-behavior-longhands-logical TESTS: wpt/css/css-overscroll-behavior/ovescroll-behavior-logical.html, wpt/css/css-overscroll-behavior/parsing/* Bug: 833953 Change-Id: I5ceefa0afb1913472c0e134b2ec07405154abfae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614026 Reviewed-by: Rick Byers <rbyers@chromium.org> Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Majid Valipour <majidvp@chromium.org> Auto-Submit: Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#676042}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-1614026
branch
from
ec1d0b2
to
a5df2a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flow relative longhands have been added to overscroll-behavior
specification [1]. This CL implements the relevant css parsing
and matching tests.
minor change: collapse all overscrollBehavior related case
statements in parser fast path.
intent-to-ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/V86fOkIaEQA/JydSaafqBwAJ
[1] https://drafts.csswg.org/css-overscroll-behavior-1/#overscroll-behavior-longhands-logical
TESTS: wpt/css/css-overscroll-behavior/ovescroll-behavior-logical.html, wpt/css/css-overscroll-behavior/parsing/*
Bug: 833953
Change-Id: I5ceefa0afb1913472c0e134b2ec07405154abfae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1614026
Reviewed-by: Rick Byers <rbyers@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Anders Hartvoll Ruud <andruud@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Auto-Submit: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#676042}