Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Chromium based Edge for Edge test runs #16920

Merged
merged 8 commits into from
Jun 6, 2019
Merged

Use Chromium based Edge for Edge test runs #16920

merged 8 commits into from
Jun 6, 2019

Conversation

mustjab
Copy link
Contributor

@mustjab mustjab commented May 20, 2019 •
edited
Loading

This change replaces Win10 built-in Edge browser with Chromium based Edge for test runs. It uses the recently added edgechromium WPT browser.

Results diff from latest run; https://staging.wpt.fyi/results/?product=edge@dd73c48261&product=chrome@fe2961715f&diff&filter=ADC

@foolip foolip mentioned this pull request May 20, 2019
Closed
foolip
foolip reviewed May 20, 2019
View reviewed changes
tools/ci/azure/cleanup_win10.yml Outdated Show resolved Hide resolved
tools/ci/azure/install_edge.yml Outdated Show resolved Hide resolved
.azure-pipelines.yml Show resolved Hide resolved
.azure-pipelines.yml Outdated Show resolved Hide resolved
tools/ci/azure/install_edge.yml Outdated Show resolved Hide resolved
@Hexcles Hexcles mentioned this pull request May 27, 2019
Closed
@mustjab mustjab force-pushed the mustjab/edge-chromium branch from 60e4085 to d5140df Compare May 29, 2019 15:02
@wpt-pr-bot wpt-pr-bot added the wpt label May 29, 2019
@Hexcles
Copy link
Member

Hexcles commented May 30, 2019

@mustjab I just noticed that this PR would run only the canary version.

As discussed in the email off the thread, it'd be better to run the dev version, as it aligns better with the existing channels on wpt.fyi, especially with Chrome (we only have Chrome Dev but not Chrome Canary on wpt.fyi) so that we can have a more useful comparison. Feel free to have Canary in addition to Dev if you find it useful.

By the way, does Edge Chromium also have a flag to control experimental web platform features like Chrome (--enable-experimental-web-platform-features)? If so, then the convention is to turn it on when we are running dev or canary channels (Firefox and Chrome do this already).

Hexcles
Hexcles reviewed May 30, 2019
View reviewed changes
.azure-pipelines.yml Outdated Show resolved Hide resolved
@mustjab mustjab force-pushed the mustjab/edge-chromium branch from 899ca1a to f82ad92 Compare June 3, 2019 14:52
Hexcles
Hexcles reviewed Jun 3, 2019
View reviewed changes
tools/wpt/run.py Outdated Show resolved Hide resolved
@Hexcles
Copy link
Member

Hexcles commented Jun 3, 2019

I found another bug: --channel isn't being correctly plumbed. I've sent out a fix: #17147

@mustjab mustjab force-pushed the mustjab/edge-chromium branch from f4cee09 to 89d2c61 Compare June 4, 2019 16:30
Hexcles
Hexcles approved these changes Jun 4, 2019
View reviewed changes
Copy link
Member

@Hexcles Hexcles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me.

@foolip
Copy link
Member

foolip commented Jun 5, 2019

@gsnedders says they've seen the Chrome macOS infrastructure/ failures elsewhere, so this probably preexisting. @gsnedders do you have other examples, and an issue for it?

@mustjab mustjab force-pushed the mustjab/edge-chromium branch from 89d2c61 to dd73c48 Compare June 5, 2019 15:49
@Hexcles
Copy link
Member

Hexcles commented Jun 5, 2019

@foolip replying to your off-thread question here: yes this PR is safe to merge as far as wpt.fyi is concerned. I've added support for edgechromium and pushed it to prod (web-platform-tests/wpt.fyi#1342).

@foolip
Copy link
Member

foolip commented Jun 5, 2019

@mustjab it looks like you've scheduled a build that failed a lot of jobs at the checkout step. Do you want a good run before we merge this, or should we merge and see what happens?

@mustjab
Copy link
Contributor Author

mustjab commented Jun 6, 2019

@foolip Yes, i scheduled another run and updated description with results, which looked good to me.

Build: https://dev.azure.com/web-platform-tests/wpt/_build/results?buildId=18285
Results diff: https://staging.wpt.fyi/results/?product=edge@dd73c48261&product=chrome@fe2961715f&diff&filter=ADC

@Hexcles Hexcles closed this Jun 6, 2019
@Hexcles Hexcles reopened this Jun 6, 2019
@Hexcles
Copy link
Member

Hexcles commented Jun 6, 2019

One of the resources/ tests is failing: https://tools.taskcluster.net/groups/XXlYSbkyQcaiOhNxChlNFQ/tasks/Ugvmz0z7SQaMXhWcZQzc3w/runs/0/logs/public%2Flogs%2Flive.log#L483

I don't think it's caused by this change though.

@Hexcles Hexcles closed this Jun 6, 2019
@Hexcles Hexcles reopened this Jun 6, 2019
@Hexcles
Copy link
Member

Hexcles commented Jun 6, 2019

I'm squash-merging this. I'll keep an eye on the next few runs.

@Hexcles Hexcles merged commit c93c30d into master Jun 6, 2019
@foolip foolip mentioned this pull request Jun 6, 2019
Closed
@gsnedders gsnedders deleted the mustjab/edge-chromium branch June 6, 2019 21:22
@foolip
Copy link
Member

foolip commented Jun 7, 2019

We have a successful scheduled run! https://wpt.fyi/results/?run_id=230810012

@foolip foolip mentioned this pull request Jun 7, 2019
Closed
marcoscaceres pushed a commit that referenced this pull request Jul 23, 2019
@mustjab
Use Chromium based Edge for Edge test runs (#16920)
ce9f6d2 
* Replaced Edge runs with Chromium based Edge runs

* Add --yes to request to download driver

* Uninstall Edge on cleanup

* Addressed PR feedback

* Install WebDriver binary for Windows

* Switch to Dev channel and enable WebDriver tests

* Enable --enable-experimental-web-platform-features flag for Edge Dev channel runs

* Removed ChromeDriver specific hack
foolip added a commit that referenced this pull request Sep 4, 2019
@foolip
Remove infrastructure/ expectations for Edge classic
3e541d8 
We're no longer running this configuration:
#16920
@foolip foolip mentioned this pull request Sep 4, 2019
Merged
gsnedders pushed a commit that referenced this pull request Sep 12, 2019
@foolip @gsnedders
Remove infrastructure/ expectations for Edge classic (#18829)
4d2016d 
We're no longer running this configuration:
#16920
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Sep 18, 2019
@foolip @moz-wptsync-bot
Bug 1578688 [wpt PR 18829] - Remove infrastructure/ expectations for …
966d339 
…Edge classic, a=testonly

Automatic update from web-platform-tests
Remove infrastructure/ expectations for Edge classic (#18829)

We're no longer running this configuration:
web-platform-tests/wpt#16920
--

wpt-commits: 4d2016d8865b46d4b8c7d6fc5c028a631d696b69
wpt-pr: 18829
dbaron pushed a commit to dbaron/gecko that referenced this pull request Sep 19, 2019
@foolip @moz-wptsync-bot
Bug 1578688 [wpt PR 18829] - Remove infrastructure/ expectations for …
8a225db 
…Edge classic, a=testonly

Automatic update from web-platform-tests
Remove infrastructure/ expectations for Edge classic (#18829)

We're no longer running this configuration:
web-platform-tests/wpt#16920
--

wpt-commits: 4d2016d8865b46d4b8c7d6fc5c028a631d696b69
wpt-pr: 18829
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this pull request Oct 4, 2019
@marco-c
Bug 1578688 [wpt PR 18829] - Remove infrastructure/ expectations for …
3aba9f1 
…Edge classic, a=testonly

Automatic update from web-platform-tests
Remove infrastructure/ expectations for Edge classic (#18829)

We're no longer running this configuration:
web-platform-tests/wpt#16920
--

wpt-commits: 4d2016d8865b46d4b8c7d6fc5c028a631d696b69
wpt-pr: 18829

UltraBlame original commit: 4e4a8d3a74ad453b22b5ac5f92e29c28b0c4e8e0
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this pull request Oct 4, 2019
@marco-c
Bug 1578688 [wpt PR 18829] - Remove infrastructure/ expectations for …
c7c99d6 
…Edge classic, a=testonly

Automatic update from web-platform-tests
Remove infrastructure/ expectations for Edge classic (#18829)

We're no longer running this configuration:
web-platform-tests/wpt#16920
--

wpt-commits: 4d2016d8865b46d4b8c7d6fc5c028a631d696b69
wpt-pr: 18829

UltraBlame original commit: 4e4a8d3a74ad453b22b5ac5f92e29c28b0c4e8e0
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this pull request Oct 4, 2019
@marco-c
Bug 1578688 [wpt PR 18829] - Remove infrastructure/ expectations for …
766f2fc 
…Edge classic, a=testonly

Automatic update from web-platform-tests
Remove infrastructure/ expectations for Edge classic (#18829)

We're no longer running this configuration:
web-platform-tests/wpt#16920
--

wpt-commits: 4d2016d8865b46d4b8c7d6fc5c028a631d696b69
wpt-pr: 18829

UltraBlame original commit: 4e4a8d3a74ad453b22b5ac5f92e29c28b0c4e8e0
Hexcles added a commit that referenced this pull request Nov 13, 2019
@Hexcles
[wpt] Enable experimental features for Edge Canary
3347837 
PR #16920 added Edge Dev & Canary to Azure but only enabled experimental
web platform features for Dev.
@Hexcles Hexcles mentioned this pull request Nov 13, 2019
Merged
Hexcles added a commit that referenced this pull request Nov 22, 2019
@Hexcles
[wpt] Enable experimental features for Edge Canary
c5766f8 
PR #16920 added Edge Dev & Canary to Azure but only enabled experimental
web platform features for Dev.
Hexcles added a commit that referenced this pull request Nov 22, 2019
@Hexcles
[wpt] Enable experimental features for Edge Canary
e0bd3bf 
PR #16920 added Edge Dev & Canary to Azure but only enabled experimental
web platform features for Dev.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foolip foolip foolip left review comments

@thejohnjansen thejohnjansen thejohnjansen left review comments

@Hexcles Hexcles Hexcles approved these changes

@gsnedders gsnedders Awaiting requested review from gsnedders

@jgraham jgraham Awaiting requested review from jgraham

@jugglinmike jugglinmike Awaiting requested review from jugglinmike

Assignees

@jugglinmike jugglinmike

Labels
Azure Pipelines ci infra wpt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mustjab @Hexcles @foolip @jugglinmike @thejohnjansen @wpt-pr-bot